Repository navigation
test: make the Recall heartbeat planning setup and locked-store checks deterministic - #1538
Merged
Merged
Conversation
…s deterministic The ClickHouse invocations plan test gave recall_heartbeats a part with a setup row that set only invocation_id, so its start time defaulted to 1970. The table's TTL removes such a row as it is inserted and drops the empty part shortly after, so whenever the build wrote no heartbeat of its own the plan read nothing from the table. The setup row now starts now. The locked-store test also counts the work the locked build did: its closing notice reports dropped records and no failures, and after the lock is released only the other builds are recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two Recall tests dropped merge-queue entries on unrelated changes. The ClickHouse
invocationsplan test still had a race: its setup heartbeat set onlyinvocation_id, so its start time defaulted to 1970. The table's TTL drops such a row as it is inserted and removes the empty part about 2 s later, after which the plan reads nothing fromrecall_heartbeatswhenever the build wrote no heartbeat of its own. The locked-store test checked only the notice and a hang guard, not the work the locked build did.Changes
now64(6), so the table keeps its part until the plan is read.DuckShop: no case applies; this changes test setup and assertions only, not a project shape, data value or lifecycle sequence.
Verification
make check-cipasses.