Repository navigation
ci: report release performance runs that do not finish - #1536
Merged
Merged
Conversation
A main comparison that hung ran into the job timeout, lost its log and evidence upload, and reported nothing. The comparison step now has its own limit below the job's, setup commands stop with an error naming their phase, each phase is listed in the job summary as it starts, and a main run that errors, loses its runner or times out opens or updates one release-performance-unfinished issue. Runs cancelled by concurrency or by hand are not reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A main Release Performance run hung in the comparison step and ran into the 90 minute job timeout. GitHub then cancelled the job: no log, no evidence upload, no issue. A timed-out comparison passed silently.
Changes
release-performance-unfinishedissue. A failed compare job (step error, step timeout, lost runner) is reported. A cancelled one is reported only when its annotations carry GitHub's job-timeout message. Runs cancelled by a newer run or by hand carry other annotations and are not reported. The classifier uses only the standard library, so the report job skips the dependency install.DuckShop: no case applies; this changes CI tooling only, not compiler, Rules or lifecycle behaviour.
Verification
-Sto prove no third-party imports.sqb --versionfail with the phase named.make check-cipass;make testpasses apart from the Postgres publication tests, which need Docker.