Repository navigation
fix: stop a single custom-rule host at its next invocation when interrupted - #1535
Merged
Merged
Conversation
…rupted Ctrl-C during custom rules that run on one host, the default for small projects, waited until that host had run every invocation. Only split hosts had a cancellation marker; a single-host run, the single-host fallback after a failed split and the stateful rerun had none, and the fallback did not check for interrupts at all. Every host run now gets its own cancellation marker and waits for its host the way split hosts do, so an interrupt stops the host after the invocation in flight. Module-state detection, which the marker used to switch on, is now its own flag, still set only for split hosts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pressing Ctrl-C while custom rules ran on a single host, the default for small projects, waited until that host had run every invocation. Only split hosts had a cancellation marker. A single-host run, the single-host fallback after a failed split and the stateful rerun had none, and the fallback did not check for interrupts at all.
Changes
detect_stateflag on the host payload andCustomHostPartition, still set only for split hosts, so slice output and caching are unchanged.DuckShop: no case applies; this changes interrupt handling, not a project shape, data value or lifecycle sequence.
Verification
KeyboardInterruptwith at most one invocation started after the interrupt, the expected number of host launches, no host inputs and no child processes left. It fails on the previous code.make check-cipasses.make testpasses apart from the Postgres publication tests, which need Docker and can't run in this environment.