Repository navigation
refactor: move the compile layer of the Python bindings into sqlbuild-python-compile - #1526
Merged
Merged
Conversation
…-python-compile sqlbuild-python is still over the crate size limit. The compile layer (compile command and driver, input loops, compile-input attachment, project assembly, analysis and the analysis session, Rules, lineage, semantic checks, compile deltas and outputs, the DAG artifact, manifest, frontier, offline scope facts, SQL test glue and auditing) moves into a new crate above sqlbuild-python-project and beside sqlbuild-python-planner. Neither depends on the other. Command handlers that also reach the planner stay in sqlbuild-python. Old paths are deleted and callers updated; there are no re-exports. main/ entries hold the bodies they used to forward to, except 13 whose bodies are over the entry size budgets. The sqlbuild-python cap drops to its new size, XSB072/XSB073 budgets are re-keyed with unchanged totals, and the native field fallback list and compiler-differential scan paths follow the moved files.
kvlonge
enabled auto-merge
November 16, 2026 22:23
kvlonge
added a commit
that referenced
this pull request
Nov 17, 2026
Moves the compile layer from the bindings crate into the new sqlbuild-python-compile crate, as the slice did, keeping the large-project tree's behaviour. Where the tree and the slice's base differ: - the tree's build_effective_target_namespace stays registered, through a compile-crate wrapper; main's newer target-settings entries, which the tree does not have, are not carried over; - integration_loaders stays deleted, as the tree removed the dlt and ingestr integrations; - the model-loop compile pool keeps using sqlbuild-python-base, where the previous slice put it; - rules_at_load stays in the bindings crate's compile_driver. Validation: cargo check --workspace --all-targets passes with no warnings, the layout matches the slice apart from the items above, and every line the tree added to a moved file is still present. Nothing is built or tested yet. fensu reports 346 faults, unchanged from the previous slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlbuild-pythonis still over the crate size limit. This slice moves the compile layer into its own crate.Changes
sqlbuild-python-compile, abovesqlbuild-python-projectand besidesqlbuild-python-planner(neither depends on the other), holds the compile command and driver, input loops, compile-input attachment, project assembly, analysis and the analysis session, Rules, lineage, semantic checks, compile deltas and outputs, the DAG artifact, manifest, frontier, offline scope facts, SQL test glue and auditing. Old paths are deleted and callers updated; there are no re-exports. The command handlers that also reach the planner stay insqlbuild-python.main/entries hold the bodies they forwarded to; 13 still forward because their bodies are over the entry size budgets.sqlbuild-pythoncap drops to 66,831 code lines and 93 buckets; XSB072/XSB073 budgets are re-keyed with unchanged totals.[dupes]entries cover clusters main already had whose members moved. The native field fallback list and the compiler-differential scan paths follow the moved files.Code-line growth of the
sqlbuild-python*crates:main/entry functionsuselinesmodlinesNo DuckShop case: this is a behaviour-neutral Rust move with no new project shape, value or lifecycle.
Verification
_nativesurface is identical to main's build.make check-cipassed.make test: 12,298 passed; the 3 failures need an installedsqbof this version or are interrupt timings that pass alone, as on main.