Repository navigation
fix: give the refused FULL backfill of a cursor-intrinsic model its own code S204 - #1525
Merged
Merged
Conversation
…wn code A FULL backfill of a non-microbatch model whose SQL reads __cursor_start() or __cursor_end() is refused, because a full rebuild has no cursor interval. The refusal used the planner's default code S000, so the plan JSON, the control API and the UI could not tell it apart from any other planner input error. It now fails with S204, listed with the other planner codes, keeping its message and the remedy that names --start-cursor-ts and --end-cursor-ts.
…de in the unit test
# Conflicts: # fensu.toml
# Conflicts: # crates/sqlbuild-python-planner/src/planner_resolution/_helpers/references/orchestration.rs # crates/sqlbuild-python/src/bindings/_helpers/planner_phases/constants.rs # fensu.toml
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A FULL backfill of a non-microbatch model whose SQL reads
__cursor_start()or__cursor_end()is refused, because a full rebuild has no cursor interval. The refusal used the planner's default codeS000, so the plan JSON, the control API and the UI could not tell it apart from any other planner input error.Changes
S204, listed with the other planner codes. Its message and the remedy naming--start-cursor-tsand--end-cursor-ts(or the-intforms) are unchanged.S204and every way a model is planned as a FULL backfill; the skill is regenerated.Verification
S204code; the own-change replay E2E asserts it insqb plan --json --full-refreshoutput and the text error. 16 targeted tests pass.make check-cipassed before merging main; after the merge, fensu and the targeted tests pass.DuckShop: no edge case. This changes the code of an existing refusal on the planning path; DuckShop's projects build successfully and have no refused FULL backfill to carry it.