Skip to content

fix: give the refused FULL backfill of a cursor-intrinsic model its own code S204 - #1525

Merged
kvlonge merged 7 commits into
mainfrom
fix/full-backfill-code
Nov 16, 2026
Merged

kvlonge merged 7 commits into
mainfrom
fix/full-backfill-code

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Why

A FULL backfill of a non-microbatch model whose SQL reads __cursor_start() or __cursor_end() is refused, because a full rebuild has no cursor interval. The refusal used the planner's default code S000, so the plan JSON, the control API and the UI could not tell it apart from any other planner input error.

Changes

  • The refusal now fails with S204, listed with the other planner codes. Its message and the remedy naming --start-cursor-ts and --end-cursor-ts (or the -int forms) are unchanged.
  • The incremental concepts page names S204 and every way a model is planned as a FULL backfill; the skill is regenerated.
  • fensu: +3 code lines in sqlbuild-python-planner, which stays under the default limit; no cap changes.

Verification

  • Unit test for the cursor-intrinsic planner check asserts the S204 code; the own-change replay E2E asserts it in sqb plan --json --full-refresh output and the text error. 16 targeted tests pass.
  • fensu clean and make check-ci passed before merging main; after the merge, fensu and the targeted tests pass.

DuckShop: no edge case. This changes the code of an existing refusal on the planning path; DuckShop's projects build successfully and have no refused FULL backfill to carry it.

…wn code

A FULL backfill of a non-microbatch model whose SQL reads __cursor_start()
or __cursor_end() is refused, because a full rebuild has no cursor
interval. The refusal used the planner's default code S000, so the plan
JSON, the control API and the UI could not tell it apart from any other
planner input error.

It now fails with S204, listed with the other planner codes, keeping its
message and the remedy that names --start-cursor-ts and --end-cursor-ts.
@chio-labs-delivery
chio-labs-delivery Bot added this pull request to the merge queue Nov 16, 2026
@kvlonge
kvlonge removed this pull request from the merge queue due to a manual request Nov 16, 2026
# Conflicts:
#	crates/sqlbuild-python-planner/src/planner_resolution/_helpers/references/orchestration.rs
#	crates/sqlbuild-python/src/bindings/_helpers/planner_phases/constants.rs
#	fensu.toml
@chio-labs-delivery
chio-labs-delivery Bot added this pull request to the merge queue Nov 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 16, 2026
@kvlonge
kvlonge added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit f33eb8d Nov 16, 2026
35 checks passed
@kvlonge
kvlonge deleted the fix/full-backfill-code branch November 16, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant