Repository navigation
refactor: move the plan layer of the Python bindings into sqlbuild-python-planner - #1523
Merged
Merged
Conversation
…e plan layer The plan layer moves into its own crate next. Two pieces it uses sat in sqlbuild-python although their layer is lower: the planner scope resolution (project layer) and the cost attribution context (front layer). They now live in sqlbuild-python-project and sqlbuild-python-front, and their callers import them from there.
…thon-planner Work in progress: the move itself. main/ forwarders are not folded yet, and the field-fallback list, duplicate allowlist and crate README are not updated.
…ct the register allowlist reason
kvlonge
enabled auto-merge
November 16, 2026 19:34
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 16, 2026
# Conflicts: # crates/sqlbuild-python/src/bindings/_helpers/build_command/command.rs # crates/sqlbuild-python/src/bindings/_helpers/build_command/execution.rs # crates/sqlbuild-python/src/bindings/_helpers/sql_test_command/test_command.rs # fensu.toml
kvlonge
enabled auto-merge
November 16, 2026 20:34
kvlonge
added a commit
that referenced
this pull request
Nov 17, 2026
Moves the plan layer from the bindings crate into the new sqlbuild-python-planner crate, as the slice did, keeping the large-project tree's behaviour. Where the large-project tree had modules the slice never saw: - the planner warehouse reads, synced reads and plan timings moved into the planner crate (planner_warehouse and planner_phases); - the live warehouse reads moved into their own planner-crate module, live_reads, outside the planner paths XSB080 guards, as native_host kept them before; - the rayon compile pool moved to sqlbuild-python-base native_threads. fensu.toml keeps the tree's XSB079 and XSB080 entries at their new paths. Validation: cargo check --workspace --all-targets passes with no warnings, and the layout matches the slice. Nothing is built or tested yet. fensu reports 346 faults (287 after the previous slice); the new ones are path-keyed budgets, layout and visibility faults for the final pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlbuild-pythonis still over the crate size limit. This slice moves the plan layer into its own crate.Changes
sqlbuild-python-planner, abovesqlbuild-python-project, holds the planner areas (entries, phases, changes, migrations, resolution, scenarios, strategy, warehouse) plus freshness, consumption, microbatches, observations, lifecycle events and plan output. Old paths are deleted and callers updated; there are no re-exports.sqlbuild-python-projectand the cost context intosqlbuild-python-front, so the plan layer depends only downward.main/entries hold the bodies they forwarded to; 39 still forward because their bodies are over the entry size budgets. Imports are regrouped where the source grouped them.sqlbuild-pythoncap drops to 115,238 code lines; XSB072/XSB073 budgets are re-keyed with unchanged totals.[dupes]entries cover clusters main already had whose members moved. The native field fallback list follows the moved read sites.Code-line growth of the
sqlbuild-python*crates:main/entry functionsuselinesmodlinesThe fold adds 245
main/entry files, each with its own signature,useandmodlines.No DuckShop case: this is a behaviour-neutral Rust move with no new project shape, value or lifecycle.
Verification
_nativesurface is identical to main's build.make check-cipassed; after merging main, fensu and clippy pass.make test: 12,297 passed; the 14 failures need Docker or an installedsqb, or are interrupt timings that pass alone, as on main.