Repository navigation
test: count allocations in the reachability scaling guard and fix the runtime package cap - #1521
Merged
Merged
Conversation
A fixed cap avoids raising it in every pull request while the crate split and UI work land. Reducing it again is in the backlog.
The guard compared wall time for 500 and 2,000 modules, which flakes on shared runners. It now counts heap allocations in its own test binary, so no other test adds to the count. Today the count grows 3.95x for 4x the modules; copying the dead-code context into every file call grows it 7.58x, and the quadratic parent lookup in fensu 0.31.0 grows it 8.14x. Both fail the bound of 5.
kvlonge
enabled auto-merge
November 16, 2026 17:03
kvlonge
disabled auto-merge
November 16, 2026 17:21
kvlonge
enabled auto-merge
November 16, 2026 17:21
kvlonge
marked this pull request as draft
November 16, 2026 17:22
auto-merge was automatically disabled
November 16, 2026 17:22
Pull request was converted to draft
kvlonge
marked this pull request as ready for review
November 16, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The runtime package's code-line cap was raised in many pull requests. It is now a fixed 100,000 while the crate split and UI work land.
The unreachable-definitions scaling guard compared wall time for 500 and 2,000 modules, so it could flake on shared runners. CI gates should count work instead.
Changes
fensu.toml: thesrc/sqlbuildcap is 100,000 with a new reason, and the "Raised from" history lines are gone.stats_alloc, dev-only) in its own integration-test binary,crates/sqlbuild-rules/tests/python_rules.rs, so no other test adds to the count. The timing version is removed from the unit tests.No DuckShop case: this changes a Rust test and a lint setting, with no project shape, value or lifecycle.
Verification
Allocation growth for 4x the modules, against a bound of 5.0:
cargo test -p sqlbuild-rulespasses.make check-cipasses.make test: 12,307 passed; the 4 failures need Docker, which this machine lacks.