Skip to content

test: count allocations in the reachability scaling guard and fix the runtime package cap - #1521

Merged
chio-labs-delivery[bot] merged 2 commits into
mainfrom
chore/runtime-package-cap
Nov 16, 2026
Merged

chio-labs-delivery[bot] merged 2 commits into
mainfrom
chore/runtime-package-cap

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Why

The runtime package's code-line cap was raised in many pull requests. It is now a fixed 100,000 while the crate split and UI work land.

The unreachable-definitions scaling guard compared wall time for 500 and 2,000 modules, so it could flake on shared runners. CI gates should count work instead.

Changes

  • fensu.toml: the src/sqlbuild cap is 100,000 with a new reason, and the "Raised from" history lines are gone.
  • The guard now counts heap allocations (stats_alloc, dev-only) in its own integration-test binary, crates/sqlbuild-rules/tests/python_rules.rs, so no other test adds to the count. The timing version is removed from the unit tests.

No DuckShop case: this changes a Rust test and a lint setting, with no project shape, value or lifecycle.

Verification

Allocation growth for 4x the modules, against a bound of 5.0:

build growth
this branch 3.95x (stable across runs)
dead-code context copied into every file call 7.58x, fails
fensu 0.31.0 (quadratic parent lookup) 8.14x, fails
  • cargo test -p sqlbuild-rules passes.
  • make check-ci passes. make test: 12,307 passed; the 4 failures need Docker, which this machine lacks.

A fixed cap avoids raising it in every pull request while the crate split
and UI work land. Reducing it again is in the backlog.
The guard compared wall time for 500 and 2,000 modules, which flakes on
shared runners. It now counts heap allocations in its own test binary,
so no other test adds to the count. Today the count grows 3.95x for 4x
the modules; copying the dead-code context into every file call grows
it 7.58x, and the quadratic parent lookup in fensu 0.31.0 grows it 8.14x.
Both fail the bound of 5.
@kvlonge
kvlonge enabled auto-merge November 16, 2026 17:03
@kvlonge
kvlonge disabled auto-merge November 16, 2026 17:21
@kvlonge
kvlonge enabled auto-merge November 16, 2026 17:21
@kvlonge
kvlonge marked this pull request as draft November 16, 2026 17:22
auto-merge was automatically disabled November 16, 2026 17:22

Pull request was converted to draft

@kvlonge
kvlonge marked this pull request as ready for review November 16, 2026 17:22
@kvlonge kvlonge closed this Nov 16, 2026
@kvlonge kvlonge reopened this Nov 16, 2026
@kvlonge kvlonge closed this Nov 16, 2026
@kvlonge kvlonge reopened this Nov 16, 2026
@chio-labs-delivery
chio-labs-delivery Bot added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit bc20006 Nov 16, 2026
113 of 119 checks passed
@chio-labs-delivery
chio-labs-delivery Bot deleted the chore/runtime-package-cap branch November 16, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant