Repository navigation
refactor: move the project layer of the Python bindings into sqlbuild-python-project - #1520
Merged
Merged
Conversation
…ython-front Discovery, model configuration and headers, scopes, macro rendering and authored values, SQL text, model attachment and the compile driver, cursors, contract and refactor facts, and the consumption, observation and audit result state tables move into a new crate between sqlbuild-python-base and sqlbuild-python, one area per helper bucket. sqlbuild-python imports their entry points directly; the extension module surface is unchanged.
…servation boundary The observation boundary matched `observations_state` as a whole word, so the `append_observations` and `register_observations_state` entries the front crate exports, and the files that call them, fell outside it after the move. The pattern now names both entries, and their callers are listed again.
Incomplete: both crates compile with no warnings; fensu layout findings (helper containers, models roles, tuple arity, Debug derives) and the pipeline's budget, allowlist and readme steps are still open. Not tested.
Groups the moved helper modules into buckets, splits the snapshot and resource views into their own areas, keeps the native_host edge, and records Debug and record-tuple exceptions. fensu check passes; new duplicate clusters are not allowlisted yet. Not tested.
Gives each cluster the move touches a reason in [dupes]; fensu dupes reports no new clusters against the slice base. Not tested.
Keeps both rules imports, and sets the sqlbuild-python cap to the measured 169,863 code lines (main's 72 added lines on top of 169,791).
SchemaHandles prints no fields again, so audit arguments stay out of Debug output. Removes the budgets of the deleted bindings/models.rs and merges repeated duplicate allowlist entries.
kvlonge
enabled auto-merge
November 16, 2026 15:36
# Conflicts: # crates/sqlbuild-python/src/bindings/_helpers/planner_strategy/constants.rs # crates/sqlbuild-python/src/bindings/_helpers/planner_strategy/model_entries.rs # fensu.toml
kvlonge
disabled auto-merge
November 16, 2026 15:55
kvlonge
added a commit
that referenced
this pull request
Nov 17, 2026
Slice 4 of the large-project integration replay. Moves the planner, graph, fingerprint, analysis and resource-view helpers into the project crate as #1520 did, keeping the large-project tree's own changes (relation-name prefetch, dialect-bound planner strategy, live reads). Validation so far: cargo check --workspace --all-targets passes with no warnings, and the file layout matches #1520's tree. Not built or tested yet. fensu check reports about ten more layout faults than the previous wip commit; they are left for the final pass after the main merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlbuild-pythonis over the crate size limit. This slice moves the project layer into its own crate and removes the one-linemain/forwarders the split added, here and insqlbuild-python-front.Changes
sqlbuild-python-projectholds the compiled project and its views, graph, planner, analysis session, SQL test glue, snapshot, references, lineage, fingerprints and contracts. Every old path is deleted and its callers updated. There are no re-exports.main/entry now holds the body it used to forward to, assqlbuild-rulesdoes._helpersimports it back where needed. 37 entries still forward because their bodies are over the entry size budgets.sqlbuild-pythoncap is lowered, and XSB072/XSB073 budgets are re-keyed (totals 3,603→3,602 and 1,520→1,517). Allowlist entries cover existing duplicates the move touched.Code-line growth of the
sqlbuild-python*crates:main/forwarders (bodies,use,mod)uselines13 of the +1,329 name long record tuples for clippy.
Public records stay written out: they live in
models.rs, where FPRSR001 allows no macro calls.No DuckShop case: this is a behaviour-neutral Rust move with no new project shape, value or lifecycle.
Verification
_nativesurface is identical to main's build.make check-cipassed;make test: 12,296 passed; 14 failures are the known local ones that need Docker or an installedsqbas on slice 3.