Repository navigation
refactor: move the front layer of the Python bindings into sqlbuild-python-front - #1516
Merged
Merged
Conversation
…ython-front Discovery, model configuration and headers, scopes, macro rendering and authored values, SQL text, model attachment and the compile driver, cursors, contract and refactor facts, and the consumption, observation and audit result state tables move into a new crate between sqlbuild-python-base and sqlbuild-python, one area per helper bucket. sqlbuild-python imports their entry points directly; the extension module surface is unchanged.
…servation boundary The observation boundary matched `observations_state` as a whole word, so the `append_observations` and `register_observations_state` entries the front crate exports, and the files that call them, fell outside it after the move. The pattern now names both entries, and their callers are listed again.
Keeps both rules imports, and sets the sqlbuild-python cap to the measured 169,863 code lines (main's 72 added lines on top of 169,791).
kvlonge
marked this pull request as ready for review
November 16, 2026 12:56
kvlonge
enabled auto-merge
November 16, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlbuild-pythonis still far above the crate size limit. This third slice moves the front of the compile pipeline into a new crate,sqlbuild-python-front, betweensqlbuild-python-baseandsqlbuild-python.Changes
sqlbuild-python-front(144 modules): discovery, model configuration and headers, scopes, macro rendering and authored values, SQL text, model attachment and the compile driver, cursors, contract and refactor facts, and the consumption, observation and audit-result state tables. Same layout as the base crate.sqlbuild-pythonimports from the front crate directly; there are no shims. Scripts rewrote imports,fensu.tomlandtests/native_field_fallbacks.txt.positional_record!calls inmodels.rsbecome plain structs with tuple conversions.NativeConfigErrormoves toerrors.rs.Locations::sharedandHeaderValues::sharedshare one helper; stale[dupes]entries go, new clusters get reasons.sqlbuild-python197,963 → 169,863 code lines after mergingmain. Combined delta across the three binding crates is +4,767 (222,122 → 226,889; front holds 32,867), mostly the 390 one-functionmain/entry files the layout requires.No DuckShop case applies: this changes only where binding code lives, not compiler behaviour.
Verification
_nativesurface (names, kinds, signatures, members) identical tomain.fensu check,fensu dupes --fail-on-new, the native layering, stub, build-features and boundary checks,make check-ci.make testfails only environment-bound tests that fail onmainhere too.