Repository navigation
refactor: move the shared runtime of the Python bindings into sqlbuild-python-base - #1514
Merged
Merged
Conversation
…d-python-base The native store, compile context, diagnostics, progress and terminal text, warehouse access, orchestration reads and the other infra-layer helper modules move into the base crate, one area per helper bucket. sqlbuild-python imports their entry points directly; the extension module surface is unchanged.
…infra # Conflicts: # fensu.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlbuild-pythonis still far above the crate size limit. This second slice moves the shared runtime the command bindings stand on intosqlbuild-python-base, the bottom binding layer, and consolidates the duplicate clusters those files belonged to.Changes
sqlbuild-python-base(about 8.5k code lines): boundary conversions, native classes, host calls and threads, compile context, diagnostics, event exporting, frontier, cache, CLI documents, progress, result output, warehouse access and presentation text.sqlbuild-pythonimports from the base directly, with no shims; a script rewrote the imports and the paths intests/native_field_fallbacks.txt.new_plain_errorandhost_error, the UTF-16 conversions share one helper, and the context variables sharecontext_variable; six[dupes]entries are removed. Three clusters the move newly exposes are listed with reasons.No DuckShop case applies: only where binding code lives changes, not compiler behaviour.
Verification
_nativesurface (names, kinds, signatures, class members) is identical tomain.main, alternating on one 8-core machine (load 3.2–3.6): compile JSON and all 11,175 compiled files identical. Cold, median of 7: wall 9.02 → 8.69 s, CPU 28.06 → 27.43 s. Warm and one-model edit, median of 3: wall 0.61 → 0.61 s and 1.84 → 1.78 s. Neutral.sqlbuild-python(--profile fast), 3 locations × 2 runs alternating, load 3.4–6.5: median wall 39.5 → 36.4 s, user CPU 90 → 100 s. Neutral.fensu check,fensu dupes --fail-on-new,make check-ci;make testfails only environment-bound tests that fail onmainhere too.