Skip to content

fix: stabilise Recall tests, janitor preserve targets and helper-class identity - #1512

Merged
chio-labs-delivery[bot] merged 11 commits into
mainfrom
feat/recall-batch
Nov 16, 2026
Merged

chio-labs-delivery[bot] merged 11 commits into
mainfrom
feat/recall-batch

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Why

Two Recall tests dropped merge-queue entries on unrelated changes: one compared wall time with a budget on a busy runner, the other ran EXPLAIN before the heartbeats table had a part. Janitor planning read a preserve target schema as a name. A helper class lost its file once discovery restored another python package, so it and its callees dropped out of a Python node's identity.

Changes

  • Recall tests: heartbeats get a part before the invocations view is planned. Locked-store tests check the close deadline (one budget after it begins) and the shutdown-timeout notice, with a 60 s hang guard instead of a wall-time budget. The start-delay test is removed: wait_for_setup(ZERO) makes its timing unobservable.
  • Janitor planning treats a preserve target schema or database as no location.
  • Python identity finds a class's file, source and globals through a method defined in its body. Only real functions, staticmethods and classmethods are unwrapped, so an attribute whose __getattr__ returns a new wrapper cannot crash it. On Python 3.13+, class source is read at __firstlineno__.
  • Code-line caps raised to measured sizes: bindings crate 206,364 → 206,368 (janitor planning), runtime package 89,626 → 89,643 (identity anchors; 3 of the lines are the wrapper fix).

Verification

  • New cases fail without the fix: a helper called from a class method stays a dependency; the __getattr__ wrapper class; preserve target schema and database are never inspected (real ones are); doubling the close deadline fails the held-lock Rust test.
  • Class source matches inspect.getsource for every DuckShop class shape on Python 3.12 and 3.13.
  • Targeted Rust and Python tests, Recall E2E tests and the ClickHouse heartbeat case pass; make check-ci passes.

DuckShop: no new case. The identity failure needs a non-project python package imported before discovery, which a project cannot express. The janitor fix concerns target settings, not a project shape.

@chio-labs-delivery
chio-labs-delivery Bot added this pull request to the merge queue Nov 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 16, 2026
@kvlonge
kvlonge added this pull request to the merge queue Nov 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 16, 2026
@chio-labs-delivery
chio-labs-delivery Bot added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 9ca1f7a Nov 16, 2026
32 checks passed
@chio-labs-delivery
chio-labs-delivery Bot deleted the feat/recall-batch branch November 16, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant