Repository navigation
fix: stabilise Recall tests, janitor preserve targets and helper-class identity - #1512
Merged
Merged
Conversation
…g (unbuilt work in progress)
…so its callees stay identity dependencies after discovery restores another python package
… given instead of runner wall time
…_firstlineno__ first
… a preserve target database in janitor planning
… their re-measured sizes
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 16, 2026
# Conflicts: # fensu.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two Recall tests dropped merge-queue entries on unrelated changes: one compared wall time with a budget on a busy runner, the other ran EXPLAIN before the heartbeats table had a part. Janitor planning read a
preservetarget schema as a name. A helper class lost its file once discovery restored anotherpythonpackage, so it and its callees dropped out of a Python node's identity.Changes
wait_for_setup(ZERO)makes its timing unobservable.preservetarget schema or database as no location.__getattr__returns a new wrapper cannot crash it. On Python 3.13+, class source is read at__firstlineno__.Verification
__getattr__wrapper class;preservetarget schema and database are never inspected (real ones are); doubling the close deadline fails the held-lock Rust test.inspect.getsourcefor every DuckShop class shape on Python 3.12 and 3.13.make check-cipasses.DuckShop: no new case. The identity failure needs a non-project
pythonpackage imported before discovery, which a project cannot express. The janitor fix concerns target settings, not a project shape.