Repository navigation
fix(worker): fail a function whose unit test fails, and name it on downstream skips - #1471
Merged
Merged
Conversation
…wnstream skips A function is built before its unit tests run, so a worker build reported it as a success even when a test then failed, and the models calling it were skipped with no cause. The worker now holds a built function's result until every test that checks it has reported. A failing test records the function as failed with the test's error, so the run page, the Failures list and "Rerun from failure" point at it. Results still held when the build ends are published as they were.
kvlonge
enabled auto-merge
November 14, 2026 04:21
Both cases failed, so which one the worker recorded against the model depended on execution order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A function is built before its unit tests run. On a server run, a worker reported it as a success even when one of its tests then failed, and the models calling it were skipped with no cause. The run page showed a green function next to unexplained skips, and "Rerun from failure" left the broken function out.
Changes
orchestration/worker_failed_function_test.sql.Verification
udf:udf__order_band, and both models calling it are skipped because of it. It fails on main, where the UDF reports success and the skips have no cause.test_worker.pypasses: 42 cases.make check-cipasses.