Skip to content

fix(worker): record a model blocked by a failing unit test as failed, and name the failed node on downstream skips - #1466

Merged
kvlonge merged 3 commits into
mainfrom
fix/failed-unit-test-nodes
Nov 14, 2026
Merged

kvlonge merged 3 commits into
mainfrom
fix/failed-unit-test-nodes

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Why

When a SQL unit test failed during a server run, the build skipped the model it covers, and everything downstream, exactly as the CLI does. But the worker recorded that model as a bare skip with no error. The run page then had no failed node to show, the test's error was unreachable, and "Rerun from failure" had nothing to start from. Skips inside a run named no cause, and a group's later job could say "skipped because X failed" when X was itself only skipped.

Changes

  • A failing unit test now records every model it blocks as failed, with the test's error code and message. That covers expected, assertion and reference targets, and each case of a parameterised test.
  • A node skipped within a build now records the nearest failed node upstream of it, or the cause that upstream skip already carries. Group sibling causes are kept. Test and audit runs that raise still skip unchecked nodes with no cause.
  • The worker reads the blocked models from the compiled project it has already verified against the frozen snapshot, so the published snapshot is unchanged.
  • The CLI is unchanged.
  • DuckShop edge cases cover a plain failing test, a parameterised case and an assertion-only test.

Verification

  • New worker integration test with three cases (plain, parameterised, assertion-only). All three fail on main's native code (the downstream model is skipped with no cause, and the tested model isn't failed) and pass with this change.
  • All 46 tests in test_worker.py and test_adhoc.py pass (xdist).
  • cargo clippy -p sqlbuild-python -D warnings, fensu check (0 faults), fensu dupes (no clusters) and make check-ci pass on this head.

@kvlonge kvlonge added the full-verify Run the full Verify matrix on this pull request label Nov 14, 2026
@kvlonge
kvlonge enabled auto-merge November 14, 2026 01:14
@kvlonge
kvlonge added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit d17daef Nov 14, 2026
42 of 64 checks passed
@kvlonge
kvlonge deleted the fix/failed-unit-test-nodes branch November 14, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-verify Run the full Verify matrix on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant