Repository navigation
fix(worker): record a model blocked by a failing unit test as failed, and name the failed node on downstream skips - #1466
Merged
Merged
Conversation
… and name the failed node on downstream skips
… keep check runs' skips uncaused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a SQL unit test failed during a server run, the build skipped the model it covers, and everything downstream, exactly as the CLI does. But the worker recorded that model as a bare skip with no error. The run page then had no failed node to show, the test's error was unreachable, and "Rerun from failure" had nothing to start from. Skips inside a run named no cause, and a group's later job could say "skipped because X failed" when X was itself only skipped.
Changes
Verification
test_worker.pyandtest_adhoc.pypass (xdist).cargo clippy -p sqlbuild-python -D warnings,fensu check(0 faults),fensu dupes(no clusters) andmake check-cipass on this head.