Repository navigation
ci: hold releases while a nightly Verify issue is open - #1465
Merged
Merged
Conversation
A failed nightly Verify opens an issue labelled nightly-verify. While such an issue is open, the release pull request checks fail Verify on every Release Please run, including runs that leave the pull request unchanged, and the nightly report turns off auto-merge on an open release pull request. A regression only the 5k and 10k-model jobs catch cannot ship. Closing the last open issue after a fix or a confirmed flake starts Release Please on main again, which re-checks the held pull request.
gh pr create --label can deliver labeled before opened. The later run cancels the earlier one, and the opened payload has no label, so the surviving run fell back to the fast core. Read the label and draft state from the pull request instead of the event payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The 5,000 and 10,000-model timing jobs and the full wheel set now run nightly instead of on every pull request. A regression only they catch opens a
nightly-verifyissue, but nothing stopped the next release from shipping it.Also,
gh pr create --label full-verifycan deliverlabeledbeforeopened. The later run cancels the earlier one, and theopenedpayload carries no label, so the surviving run ran only the fast core.Changes
nightly-verifyissue is open, Release Please failsVerifyon the release pull request's head ("Held by nightly Verify: …") and turns off its auto-merge. This also happens on runs that leave the pull request unchanged.release-gate-recheck.yml: when the last open issue closes and the release head is held, it starts Release Please onmain, which re-checks the pull request.full-verifyand draft state from the pull request as it is now, not from the event payload, so whichever event arrives last runs the full matrix.Verification
gh: an open issue holds the release and disables auto-merge; a hold with no open issue is lifted by a re-run; an issue closing mid-check continues; a failed issue listing holds. All cases pass.check_release_gateandcheck_docs_skillpass. Only workflows and CONTRIBUTING change, so the Rust and Python static checks don't apply.DuckShop: not applicable; this changes CI and release workflows only.