Skip to content

ci: hold releases while a nightly Verify issue is open - #1465

Merged
chio-labs-delivery[bot] merged 2 commits into
mainfrom
ci/release-gate
Nov 14, 2026
Merged

chio-labs-delivery[bot] merged 2 commits into
mainfrom
ci/release-gate

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Why

The 5,000 and 10,000-model timing jobs and the full wheel set now run nightly instead of on every pull request. A regression only they catch opens a nightly-verify issue, but nothing stopped the next release from shipping it.

Also, gh pr create --label full-verify can deliver labeled before opened. The later run cancels the earlier one, and the opened payload carries no label, so the surviving run ran only the fast core.

Changes

  • While a nightly-verify issue is open, Release Please fails Verify on the release pull request's head ("Held by nightly Verify: …") and turns off its auto-merge. This also happens on runs that leave the pull request unchanged.
  • The nightly report turns off auto-merge on an open release pull request.
  • release-gate-recheck.yml: when the last open issue closes and the release head is held, it starts Release Please on main, which re-checks the pull request.
  • Verify takes full-verify and draft state from the pull request as it is now, not from the event payload, so whichever event arrives last runs the full matrix.
  • CONTRIBUTING describes the hold.

Verification

  • Dry run of the gate, release and recheck scripts against a stub gh: an open issue holds the release and disables auto-merge; a hold with no open issue is lifted by a re-run; an issue closing mid-check continues; a failed issue listing holds. All cases pass.
  • Dry run of Verify's depth step for both delivery orders: the surviving run reads the label and runs the full matrix either way. A draft or unlabelled pull request stays on the fast core, and a merge group makes no API call.
  • actionlint shows no new findings (2 already on main). check_release_gate and check_docs_skill pass. Only workflows and CONTRIBUTING change, so the Rust and Python static checks don't apply.

DuckShop: not applicable; this changes CI and release workflows only.

A failed nightly Verify opens an issue labelled nightly-verify. While such
an issue is open, the release pull request checks fail Verify on every
Release Please run, including runs that leave the pull request unchanged,
and the nightly report turns off auto-merge on an open release pull
request. A regression only the 5k and 10k-model jobs catch cannot ship.

Closing the last open issue after a fix or a confirmed flake starts
Release Please on main again, which re-checks the held pull request.
gh pr create --label can deliver labeled before opened. The later run
cancels the earlier one, and the opened payload has no label, so the
surviving run fell back to the fast core. Read the label and draft state
from the pull request instead of the event payload.
@chio-labs-delivery
chio-labs-delivery Bot added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit 625de0f Nov 14, 2026
27 checks passed
@chio-labs-delivery
chio-labs-delivery Bot deleted the ci/release-gate branch November 14, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant