Repository navigation
fix(deps): pin SQLClean 0.9.6 and SQLQuack 0.12.1 - #1463
Merged
Merged
Conversation
SQLQuack 0.11.3, 0.12.0 and 0.12.1 read more Snowflake administration and scripting statements as Snowflake does: EXECUTE IMMEDIATE, GRANT and REVOKE, SHOW ... ROOT ONLY and ALTER DYNAMIC TABLE among them. SQLClean 0.9.6 pins the same SQLQuack, so the formatter and the compiler keep parsing one way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.11.3, 0.12.0 and 0.12.1 are released, three batches of Snowflake parser corrections. They read more administration and scripting statements as Snowflake does, such as
EXECUTE IMMEDIATE,GRANT/REVOKE,SHOW TASKS ... ROOT ONLYandALTER DYNAMIC TABLE, and refuse some forms Snowflake rejects, such as a stringSEQUENCE_NUMBERinALTER APPLICATION ... APPROVE SPECIFICATION. SQLClean 0.9.6 pins the same SQLQuack, so the formatter and the compiler parse the same way.Changes
Cargo.toml.Cargo.lockmoves only the SQLClean and SQLQuack packages.Verification
sqblink only SQLQuack 75d4c84 and SQLClean bbc94e5;Cargo.lockhas one version of each SQLQuack crate.EXECUTE IMMEDIATEandSHOW TASKS ... ROOT ONLYpasscheck, a stringSEQUENCE_NUMBERis refused, and formatting is stable on a second pass.make check-cipass.DuckShop: no case added. The changed statements are Snowflake administration and scripting statements, which a model query cannot contain, and DuckShop builds on DuckDB, which has no equivalent for its one Snowflake hook to exercise. SQLBuild code is unchanged.