Repository navigation
feat: count definition changes and stop --changed at job edges - #1458
Merged
Merged
Conversation
--changed[=definition,source_data] chooses what counts as a change, and --reach job|all stops a change at nodes another triggered job refreshes. Node status re-fingerprints recorded definitions under the snapshot's dialect before reporting a model as changed.
…own models A job's run with changed: True counts definition and source data unless [changes] counts says otherwise, and reaches its whole selection. A build that selects a job never holds back that job's models. Every counted change contributes its holding jobs, read-back follows deep chains, and planner reasons other than definition edits always count.
…odel A rebuilt upstream that read several redefined relations now reports all of them, so a model runs when any job holding one of those changes contains it, whatever order the inputs were recorded in.
kvlonge
enabled auto-merge
November 13, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
--changedcounted every new source row as a change, so a deploy-then-build rebuilt everything downstream of a streaming source, and it ran models that another scheduled job refreshes. Node status could also show unchanged models as Changed after a fingerprint scheme change.Changes
--changed[=definition,source_data]picks what counts;[changes] countssets it for a project. Without it,sqb build/plan --changedcountsdefinition, and a job's run withchanged: True(schedule, sensor or launched by hand) counts both, as before. A rebuilt upstream counts as a definition change only when its recorded executions show one, followed back through older executions.--reach job|all([changes] reach, defaultjob): a change stops at a model another triggered job refreshes. A model still runs when any job holding one of its changes, however many levels up, contains it. A job's own run, or a build that selects the job, never holds back that job's models.plan --changedlists each section and addschangedto the JSON. The UI command builder handles--flag=value.changed_builds_reach,changed_builds_two_up,changed_source_orders,fingerprint_scheme_change.Verification
test_changed_builds.py(DuckDB, SQLite) with the two-job reach scenario and changes held by two jobs two levels up; integration: a sensor on new source data still rebuilds achanged: Truejob.make check-ci.