Repository navigation
feat(ui): clearer audit, change and trigger pages, and a signed-in sqb dev UI - #1445
Merged
Merged
Conversation
…rator sqb dev now keeps one local person, an installation administrator, and mounts the person API for loopback requests as that person. The bootstrap read reports the new disabled login mode, and the UI hides Sign out there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The UI audit left a few gaps that a first user hits on admin and change pages, and
sqb devcould not serve the person API, so its embedded UI had nothing to show.Changes
sqb devkeeps one local administrator and signs every loopback request in as it. The bootstrap read reports a newdisabledlogin mode, Settings shows "Off: only reachable from this machine", and Sign out is hidden. Requests with a foreign Host or Origin are still refused. The TypeScript client is regenerated.Provider details on Locations are not included; they need the server to publish provider facts first.
Verification
make check-cipasses.cargo test -p sqlbuild-orchestrationpasses on SQLite and PostgreSQL; the development test now checks that the local person is kept across restarts and that the bootstrap read needs no sign-in.npm run checkand 225 unit tests pass.sqb devon a DuckDB project: the UI opened with no sign-in, a foreign Host got 403, and a revoked admin role came back on restart. Audit, Changes, Overview and trigger pages checked in screenshots.