Skip to content

chore(deps): pin SQLClean 0.9.4 and SQLQuack 0.11.1 - #1438

Merged
kvlonge merged 2 commits into
mainfrom
chore/pin-sqlclean-0-9-4
Nov 13, 2026
Merged

kvlonge merged 2 commits into
mainfrom
chore/pin-sqlclean-0-9-4

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Why

SQLQuack 0.11.1 reads a bare FIRST or LAST after a joined relation as that relation's alias. Before it, LEFT JOIN group_names last ON ... failed to parse, so no Rule could evaluate the model. SQLClean 0.9.4 is built on 0.11.1, so SQLBuild moves both together and resolves each crate once. The pin also brings 0.11.1's Snowflake parser additions (structured CREATE property lists, COPY FILES with quoted stages, stage paths). SQLClean's own code is unchanged between the two revisions.

Changes

  • SQLClean pinned to the 0.9.4 release commit e54722c.
  • Every SQLQuack crate pinned to the 0.11.1 release commit 62642bc1, the revision SQLClean 0.9.4 uses. Cargo.lock changes only those crates.
  • DuckShop edge case int_edge_first_last_aliases: one relation aliased first with AS, one aliased last without it, and a unit test.

Verification

  • The edge case fails to parse on main's build. With the pin, DuckShop compiles with 0 errors and 0 warnings. The unit test passes on Snowflake under the edge target and fails when an expected value is changed.
  • Fingerprints are unchanged: the SQLQuack range touches no tokenizer, fingerprint, semantics or format crate.
  • main and head built with one toolchain, compiled alternately on one machine with scripts.compare_compile_performance (cold, no cache, 3 runs each, load average about 1.5 on 8 cores; medians): dense 3,000 wall 1.030x, CPU 1.012x; fresh 3,000 wall 1.011x, CPU 1.014x; both pass.
  • Diagnostics: the dense 3,000-model project and DuckShop's existing models compile with 0 diagnostics on both builds.
  • DuckShop tests and the DuckShop compile E2E pass; make check-ci passes.

A bare FIRST or LAST after a joined relation is its alias. The case joins one relation aliased
with AS and one without, and checks on Snowflake that each alias names its own relation.
@kvlonge kvlonge added the full-verify Run the full Verify matrix on this pull request label Nov 13, 2026
@chio-labs-delivery
chio-labs-delivery Bot added this pull request to the merge queue Nov 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 13, 2026
@kvlonge
kvlonge added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 4a8f34a Nov 13, 2026
57 of 78 checks passed
@kvlonge
kvlonge deleted the chore/pin-sqlclean-0-9-4 branch November 13, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-verify Run the full Verify matrix on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant