Repository navigation
chore(deps): pin SQLClean 0.9.4 and SQLQuack 0.11.1 - #1438
Merged
Merged
Conversation
A bare FIRST or LAST after a joined relation is its alias. The case joins one relation aliased with AS and one without, and checks on Snowflake that each alias names its own relation.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.11.1 reads a bare
FIRSTorLASTafter a joined relation as that relation's alias. Before it,LEFT JOIN group_names last ON ...failed to parse, so no Rule could evaluate the model. SQLClean 0.9.4 is built on 0.11.1, so SQLBuild moves both together and resolves each crate once. The pin also brings 0.11.1's Snowflake parser additions (structuredCREATEproperty lists,COPY FILESwith quoted stages, stage paths). SQLClean's own code is unchanged between the two revisions.Changes
e54722c.62642bc1, the revision SQLClean 0.9.4 uses.Cargo.lockchanges only those crates.int_edge_first_last_aliases: one relation aliasedfirstwithAS, one aliasedlastwithout it, and a unit test.Verification
main's build. With the pin, DuckShop compiles with 0 errors and 0 warnings. The unit test passes on Snowflake under theedgetarget and fails when an expected value is changed.mainand head built with one toolchain, compiled alternately on one machine withscripts.compare_compile_performance(cold, no cache, 3 runs each, load average about 1.5 on 8 cores; medians): dense 3,000 wall 1.030x, CPU 1.012x; fresh 3,000 wall 1.011x, CPU 1.014x; both pass.make check-cipasses.