Repository navigation
perf(location): read warehouse history through one warm reader per sync - #1431
Merged
Merged
Conversation
A code location's warehouse history sync started a new interpreter, and a new warehouse login, for every 100-row page of every state table. One warm runtime interpreter now serves a whole synchronization and is closed when it completes, when project inputs change, or after a failed delivery. Remote warehouses keep one read-only session for the sync and stream each state-table scan through a bounded ordered SELECT, resuming from the keyset cursor when the window ends. Local DuckDB and SQLite files reconnect for every page so their lock never blocks other writers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A code location's warehouse history sync started a new
sqbinterpreter, and with it a new warehouse login, for every 100-row page of every state table. On a Snowflake location with about 10,000 state rows, the first sync took about 400 s and an unchanged resync about 36 s, almost all of it process start-up and login.Changes
Verification
make check-cipasses.