Skip to content

fix(deps): pin SQLClean e6ad5fa2 and SQLQuack 0.8.0 - #1429

Merged
chio-labs-delivery[bot] merged 1 commit into
mainfrom
fix/pin-sqlquack-0-8-0
Nov 12, 2026
Merged

chio-labs-delivery[bot] merged 1 commit into
mainfrom
fix/pin-sqlquack-0-8-0

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Why

SQLQuack 0.8.0 records exact select-item ranges in its strict parsers. Column expression ranges in the node SQL read were marked as strict xfails until it did: Snowflake gave aliased items no span, and DuckDB's column span left out the qualifier.

Changes

  • All SQLQuack pins move from 8d28aa4c (0.6.0) to 17088bd7 (0.8.0), and SQLClean moves from 6e18af66 to e6ad5fa2, which links the same SQLQuack. Cargo.lock changes only those packages.
  • The expression-range test no longer carries a strict xfail; its cases now pass.

No DuckShop case applies: this is a dependency pin, and the expression-range cases already cover the fixed shapes.

Verification

  • The expression-range cases pass (4/4), including the two former xfails.
  • SQLClean's format corpus is byte-identical on 0.8.0 in every dialect, so formatting doesn't change.
  • cargo test -p sqlbuild-analysis -p sqlbuild-rules: 355 + 106 pass.
  • Format and rule-position tests: 55 pass. Semantic checks and orchestration snapshot tests: 98 pass.
  • make check-ci passes.

SQLQuack 0.8.0 records exact select-item ranges in its strict parsers:
an aliased Snowflake item now has a span, and a DuckDB column's span
covers its qualifier. The expression-range cases that were strict
xfails for that gap now pass, so the xfail and its reason are removed.

SQLClean moves to e6ad5fa2, which links the same SQLQuack release; its
formatter output is unchanged.
@kvlonge kvlonge added the full-verify Run the full Verify matrix on this pull request label Nov 12, 2026
@chio-labs-delivery
chio-labs-delivery Bot added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit dc21de3 Nov 12, 2026
57 of 78 checks passed
@chio-labs-delivery
chio-labs-delivery Bot deleted the fix/pin-sqlquack-0-8-0 branch November 12, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-verify Run the full Verify matrix on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant