Skip to content

fix(rust) :: format the files cargo fmt could not see - #1378

Open
81reap wants to merge 2 commits into
sqlpage:mainfrom
81reap:sidequest/format
Open

fix(rust) :: format the files cargo fmt could not see#1378
81reap wants to merge 2 commits into
sqlpage:mainfrom
81reap:sidequest/format

Conversation

@81reap

@81reap 81reap commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Motivation

  • cargo fmt silently skipped all 38 files under sqlpage_functions/functions/.
  • Eleven of those files had drifted from the default style.

Description

Two commits in this PR.

  • 959f73ad
    • moves the module declarations out of the macro into plain mod items next to it. A function missing mod is a resolution error. An orphaned mod is a dead-code warning.
    • rust-analyzer can now resolve these modules too.
    • Adds a .git-blame-ignore-revs scaffold. We need to wait to merge into mainline to be able to pull the commit hash off mainline to ignore.
  • a732ccac runs cargo fmt --all. committed in a separate commit so that it can be added to .git-blame-ignore-revs.

Testing

n/a :: no behaviour changes

@81reap

81reap commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@lovasoa due to the .git-blame-ignore-revs, this PR should be merged as is. That way both commits independently show up at the tip of main. If you squash + merge then fix(functions) :: don't use macro to import and build SqlPageFunctionName will also be ignored

@81reap
81reap marked this pull request as ready for review August 13, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant