fix(chart) :: line series up on a category axis for every chart type - #1371
Merged
Conversation
This was referenced Aug 8, 2026
81reap
marked this pull request as draft
August 8, 2026 23:17
81reap
force-pushed
the
stack/6-chart-category
branch
3 times, most recently
from
August 12, 2026 02:05
22ccdfc to
09433d2
Compare
81reap
marked this pull request as ready for review
August 12, 2026 16:49
lovasoa
requested changes
Aug 12, 2026
lovasoa
left a comment
Collaborator
There was a problem hiding this comment.
code
SELECT 'chart' AS component, 'treemap' AS type, 'Treemap alignment regression' AS title, 420 AS height;
SELECT 'North America' AS series, 'United States' AS label, 35 AS value;
SELECT 'North America' AS series, 'Canada' AS label, 15 AS value;
SELECT 'Europe' AS series, 'France' AS label, 30 AS value;
SELECT 'Europe' AS series, 'Germany' AS label, 55 AS value;main
this pr
the black text on dark grey unreadable text bug is preexisting, but the missing label is new
81reap
force-pushed
the
stack/6-chart-category
branch
from
August 13, 2026 01:45
98f5d42 to
cca79df
Compare
Contributor
Author
|
Good catch! I aligned every chart type on a text axis except We now use an allowlist for some charts ( |
This was referenced Aug 13, 2026
lovasoa
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
bar, so alineorscatterchart whose series skip different labels draws points against the wrong ones.Description
align_seriestakes what a missing point is worth: zero to add nothing to a stack, null to leave a gap.rangeBar, whoseyis a range and whose points ApexCharts already pairs by label.Testing
area,scatterandheatmapcharts lined up on a text axis, arangeBarchart left alone, and a bubble chart keeping its point sizes.npm testchecks 41 files and reports nothing.no console errors on card pagefails for the reason described in fix(biome.js) :: fix remaining lint issues #1366, on this branch and on the unmodified base alike.GitHub cannot base a pull request on a branch that lives in a fork, so all eight target
mainand each one carries the commits of those above it. Review and merge them in order: