fix(config): raise car charging rate/threshold max to 24kW for 3-phase chargers - #4376
Open
chalfontchubby wants to merge 1 commit into
Open
Conversation
…e chargers car_charging_rate (and _1/_2/_3) and car_charging_threshold were capped at 11kW - enough for single-phase EU chargers (raised from 8.5 in springfall2008#4312) but too low for 3-phase home chargers, which commonly run up to ~22kW. Since springfall2008#4273, load_user_config() clamps input_number config items to their declared min/max even when set via apps.yaml, not just the GUI slider - so a 3-phase owner setting their real charging rate above 11kW was silently clamped down to it, capping their actual charge rate in the plan well below what their hardware can do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users with 3-phase home EV chargers have been reporting (Facebook group) that they can no longer set a car charging rate above 8.5kW / 11kW in Predbat.
car_charging_rate(and_1/_2/_3) andcar_charging_thresholdareinput_numberCONFIG_ITEMSwith a declaredmax. That max was originally8.5, then raised to11in #4312 to cover single-phase EU chargers (the Netherlands' single-phase max is 11kW) - but it's still too low for a 3-phase charger, which commonly runs up to ~22kW on a domestic supply (32A × 3 phases × 230V).The reason this now actually bites people (rather than just being a slider limit they could type past): #4273 added enforcement in
load_user_config()that clampsinput_numberconfig items to their declaredmin/maxeven when the value comes from anapps.yamloverride, not just the GUI slider - closing a real garbage-in gap for other config items, but as a side effect it also silently clamps a legitimate highcar_charging_rateset viaapps.yamldown to the old max, capping the actual planned charge rate below what the hardware can really do.Change
Raised
maxfrom11to24for:car_charging_rate,car_charging_rate_1,car_charging_rate_2,car_charging_rate_3car_charging_threshold(same power domain, subject to the identical clamp, raised for consistency)24kW gives headroom above the common ~22kW 3-phase domestic ceiling.
Test plan
unit_test.py --test integer_config(covers the clamp/type-consistency schema checks from fix(config): clamp input_number config items to their declared min/max #4273) - passesunit_test.py --quick- full suite passes🤖 Generated with Claude Code