Fix FAQ sample link#107
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the FAQ sample test link that currently points to a non-existent
app68directory.The sample exists under the current v31 test path in
springdoc-openapi, so this updates the AsciiDoc link target and visible URL to/api/v31/app68.Fixes #106.
Evidence
gh pr list -R springdoc/springdoc.github.io --state open --search '106 OR #106 OR faq.adoc OR app68 OR springdoc-openapi-actuator-webmvc-tests' --json number,title,url,author,headRefName,baseRefName,updatedAtreturned[].HTTP_STATUS=404before the edit.HTTP_STATUS=200after the edit.Verification
curl -L -o /dev/null -s -w '%{http_code}' https://github.com/springdoc/springdoc-openapi/tree/main/springdoc-openapi-tests/springdoc-openapi-actuator-webmvc-tests/src/test/java/test/org/springdoc/api/v31/app68->200git diff --check-> passedFull docs generation was not run in this environment because
mvnis not installed, there is nomvnwwrapper in the repository, andasciidoctoris not installed.