Repository navigation
Conversation
scordio
commented
Oct 12, 2026
| /** | ||
| * Default {@code RowMapper} implementations. | ||
| */ | ||
| @NullUnmarked |
Collaborator
Author
There was a problem hiding this comment.
I had to annotate all spring-batch-excel packages with @NullUnmarked as the plugin enables the RequireExplicitNullMarking checker by default, which I think it's a good practice.
Switching from @NullUnmarked to @NullMarked would require reviewing the affected classes and annotating them accordingly, but that would be beyond the scope of this PR.
scordio
force-pushed
the
nullability-maven-plugin
branch
2 times, most recently
from
October 12, 2026 17:26
dd1b829 to
60a66c1
Compare
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
scordio
force-pushed
the
nullability-maven-plugin
branch
from
October 13, 2026 08:08
60a66c1 to
fd29ea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the explicit ErrorProne and NullAway configuration with the
nullability-maven-plugin.