Clarify Vault client vs server authentication #1580 - #3300
Open
AzazelSensei wants to merge 2 commits into
Open
AzazelSensei wants to merge 2 commits into
AzazelSensei wants to merge 2 commits into
Conversation
Document when the client must send X-Config-Token, that Spring Vault is auto-configured from server properties, and that server-side tokens are renewed. Fixes spring-cloudgh-1580 Signed-off-by: Abdullah <89297042+AzazelSensei@users.noreply.github.com>
spencergibb
requested changes
Sep 18, 2026
| [[vault-authentication]] | ||
| == Client and Server Authentication | ||
|
|
||
| There are two separate questions: how Config Server authenticates to Vault, and whether a Config Client must send a Vault token. |
Member
There was a problem hiding this comment.
Reword this to not ask questions. State there are two ways to authenticate.
Author
There was a problem hiding this comment.
Reworded that to state there are two ways to authenticate.
Signed-off-by: Abdullah <89297042+AzazelSensei@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vault pages still read as if every client must send a token. I spelled out the two modes: X-Config-Token per request vs server-side authentication, that spring-vault-core auto-configures the client from spring.cloud.config.server.vault properties, and that a server token is renewed when Vault marks it renewable.
Fixes #1580