Skip to content

updated tagging workshop to resolve SSRF issue #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitchsplunk merged 1 commit into from
Jul 30, 2026
Merged

updated tagging workshop to resolve SSRF issue #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...workshops/foundations/4-solving-problems-with-o11y-cloud/3-deploy-sample-app.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def credit_check():
current_span.set_attribute("customer.num", customerNum) # <--- ADDED BY WORKSHOP

# Get Credit Score
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore?customernum=" + customerNum)
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore", params={"customernum": customerNum})
creditScoreReq.raise_for_status()
creditScore = int(creditScoreReq.text)
current_span.set_attribute("credit.score", creditScore) # <--- ADDED BY WORKSHOP
Expand All @@ -212,7 +212,7 @@ def credit_check():
current_span.set_attribute("credit.score.category", creditScoreCategory) # <--- ADDED BY WORKSHOP

# Run Credit Check
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck?customernum=" + str(customerNum) + "&score=" + str(creditScore))
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck", params={"customernum": customerNum, "score": creditScore})
creditCheckReq.raise_for_status()
checkResult = str(creditCheckReq.text)
current_span.set_attribute("credit.check.result", checkResult) # <--- ADDED BY WORKSHOP
Expand Down
8 changes: 4 additions & 4 deletions ...ent/en/scenarios/debug-problems/tagging/3-capture-tags/2-capture-tags-python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ def credit_check():
customerNum = request.args.get('customernum')

# Get Credit Score
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore?customernum=" + customerNum)
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore", params={"customernum": customerNum})
creditScoreReq.raise_for_status()
creditScore = int(creditScoreReq.text)

creditScoreCategory = getCreditCategoryFromScore(creditScore)

# Run Credit Check
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck?customernum=" + str(customerNum) + "&score=" + str(creditScore))
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck", params={"customernum": customerNum, "score": creditScore})
creditCheckReq.raise_for_status()
checkResult = str(creditCheckReq.text)

Expand Down Expand Up @@ -67,7 +67,7 @@ def credit_check():
current_span.set_attribute("customer.num", customerNum) # <--- ADDED BY WORKSHOP

# Get Credit Score
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore?customernum=" + customerNum)
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore", params={"customernum": customerNum})
creditScoreReq.raise_for_status()
creditScore = int(creditScoreReq.text)
current_span.set_attribute("credit.score", creditScore) # <--- ADDED BY WORKSHOP
Expand All @@ -76,7 +76,7 @@ def credit_check():
current_span.set_attribute("credit.score.category", creditScoreCategory) # <--- ADDED BY WORKSHOP

# Run Credit Check
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck?customernum=" + str(customerNum) + "&score=" + str(creditScore))
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck", params={"customernum": customerNum, "score": creditScore})
creditCheckReq.raise_for_status()
checkResult = str(creditCheckReq.text)
current_span.set_attribute("credit.check.result", checkResult) # <--- ADDED BY WORKSHOP
Expand Down
1 change: 1 addition & 0 deletions workshop/tagging/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
__pycache__/
6 changes: 3 additions & 3 deletions workshop/tagging/creditcheckservice-py-with-tags/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def credit_check():
current_span.set_attribute("customer.num", customerNum) # <--- ADDED BY WORKSHOP

# Get Credit Score
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore?customernum=" + customerNum)
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore", params={"customernum": customerNum})
creditScoreReq.raise_for_status()
creditScore = int(creditScoreReq.text)
current_span.set_attribute("credit.score", creditScore) # <--- ADDED BY WORKSHOP
Expand All @@ -29,7 +29,7 @@ def credit_check():
current_span.set_attribute("credit.score.category", creditScoreCategory) # <--- ADDED BY WORKSHOP

# Run Credit Check
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck?customernum=" + str(customerNum) + "&score=" + str(creditScore))
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck", params={"customernum": customerNum, "score": creditScore})
creditCheckReq.raise_for_status()
checkResult = str(creditCheckReq.text)
current_span.set_attribute("credit.check.result", checkResult) # <--- ADDED BY WORKSHOP
Expand All @@ -56,4 +56,4 @@ def getCreditCategoryFromScore(score):
return creditScoreCategory

if __name__ == '__main__':
serve(app, port=8888)
serve(app, port=8888)
6 changes: 3 additions & 3 deletions workshop/tagging/creditcheckservice-py/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ def credit_check():
customerNum = request.args.get('customernum')

# Get Credit Score
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore?customernum=" + customerNum)
creditScoreReq = requests.get("http://creditprocessorservice:8899/getScore", params={"customernum": customerNum})
creditScoreReq.raise_for_status()
creditScore = int(creditScoreReq.text)

creditScoreCategory = getCreditCategoryFromScore(creditScore)

# Run Credit Check
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck?customernum=" + str(customerNum) + "&score=" + str(creditScore))
creditCheckReq = requests.get("http://creditprocessorservice:8899/runCreditCheck", params={"customernum": customerNum, "score": creditScore})
creditCheckReq.raise_for_status()
checkResult = str(creditCheckReq.text)

Expand All @@ -50,4 +50,4 @@ def getCreditCategoryFromScore(score):
return creditScoreCategory

if __name__ == '__main__':
serve(app, port=8888)
serve(app, port=8888)
2 changes: 1 addition & 1 deletion workshop/tagging/creditprocessorservice/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def run_credit_check():
time.sleep(5)

if iScore < 300:
requests.get("http://otherservice:777/extra?customernum=" + customernum)
requests.get("http://otherservice:777/extra", params={"customernum": customernum})

return "OK"

Expand Down
Loading