Skip to content

Spin deps CLI - #3660

Merged
fibonacci1729 merged 8 commits into
mainfrom
spin-deps-cli
Sep 22, 2026
Merged

fibonacci1729 merged 8 commits into
mainfrom
spin-deps-cli

Conversation

@fibonacci1729

@fibonacci1729 fibonacci1729 commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Implementation of SIP 024.

@fibonacci1729
fibonacci1729 requested a review from itowlson August 13, 2026 19:19
@fibonacci1729 fibonacci1729 changed the title Spin deps cli Spin deps CLI Aug 13, 2026
@fibonacci1729
fibonacci1729 marked this pull request as ready for review August 13, 2026 19:22

@itowlson itowlson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I struggled with a few things I'm afraid, and I have some naming nits. My main feeling is that I would really like to see the main flows as something like:

fn add_component_dependency() {
  let component_id = select_component();         // }
  let selected_interface = select_interface();   // } as you already have it
  let inheritance = select_inheritance();        // }
  write_dependency_to_manifest();
  regenerate_dependencies_wit();
  print_report();
}

instead if inlining the last half, which for me meant I lost track of what is really a very simple linear flow.

But all that aside the bones seem really solid and it is mostly stylistic confusion on my part. Great to see this under sail!

Comment thread crates/capabilities/src/collect.rs Outdated
Comment thread crates/capabilities/src/collect.rs Outdated
Comment thread crates/capabilities/src/collect.rs Outdated
Comment thread crates/capabilities/src/collect.rs
Comment thread crates/dependency-wit/src/lib.rs Outdated
Comment thread src/commands/deps.rs Outdated
Comment thread src/commands/deps.rs
Comment thread src/commands/deps.rs Outdated
Comment thread src/commands/deps.rs Outdated
Comment thread src/commands/deps.rs Outdated
@michelleN michelleN moved this to In progress in Spin 4.2 Sep 14, 2026
@fibonacci1729
fibonacci1729 force-pushed the spin-deps-cli branch 2 times, most recently from c97e8fb to 0e0df18 Compare September 21, 2026 22:26

@itowlson itowlson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of wording and erroring suggestions which we can iterate on over time, no blockers.

I admit I found all the Wasm parser stuff a bit hairy but the main UI stuff was a model of clarity, and I really appreciate the work that went into structuring it so cleanly - thank you!

Comment thread crates/capabilities/src/collect.rs Outdated
Comment thread crates/capabilities/src/collect.rs Outdated
Comment thread crates/capabilities/src/collect.rs Outdated
Comment thread src/commands/deps/source.rs
Comment thread src/commands/deps.rs
Comment thread src/commands/deps.rs Outdated
Comment thread src/commands/deps.rs Outdated
Comment thread src/commands/deps.rs Outdated
Comment thread src/commands/deps.rs Outdated
Comment thread src/commands/deps.rs
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
@fibonacci1729
fibonacci1729 enabled auto-merge (squash) September 22, 2026 18:45
@fibonacci1729
fibonacci1729 merged commit 5401794 into main Sep 22, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Spin 4.2 Sep 22, 2026
@fibonacci1729
fibonacci1729 deleted the spin-deps-cli branch September 29, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants