Skip to content

Update trigger pluginify versions - #24

Merged
itowlson merged 2 commits into
spinframework:mainfrom
itowlson:update-pluginify-versions
Oct 6, 2026
Merged

itowlson merged 2 commits into
spinframework:mainfrom
itowlson:update-pluginify-versions

Conversation

@itowlson

@itowlson itowlson commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

So we don't need to keep updating the versions.

(The repo has a slightly funky layout but I think this will still work with the way it does the pluginifying. If not, well, back to the old way.)

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson

itowlson commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Also amended the canary workflow to hopefully NOT keep failing because "oh canary doesn't exist I can't delete it."

Sheesh.

@kate-goldenring

Copy link
Copy Markdown
Contributor

@itowlson I think i am missing context. Did the release from this PR fail so this is "bumping" a retry? https://github.com/spinframework/spin-trigger-plugins/pull/23/changes

@itowlson

itowlson commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

@kate-goldenring I didn't do a release from that because I realised I forgot to update the versions in spin-pluginify.toml (which are what gets used to make the manifests, so they have to match).

I have committed a whole comedy of errors around this update, sorry.

@kate-goldenring

Copy link
Copy Markdown
Contributor

@itowlson thanks! I see how this change makes it a single bump per trigger instead of in two places where it can get lost

@itowlson
itowlson merged commit 7f1f22f into spinframework:main Oct 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants