Repository navigation
Update trigger pluginify versions - #24
Merged
Merged
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Contributor
Author
|
Also amended the canary workflow to hopefully NOT keep failing because "oh canary doesn't exist I can't delete it." Sheesh. |
Contributor
|
@itowlson I think i am missing context. Did the release from this PR fail so this is "bumping" a retry? https://github.com/spinframework/spin-trigger-plugins/pull/23/changes |
Contributor
Author
|
@kate-goldenring I didn't do a release from that because I realised I forgot to update the versions in I have committed a whole comedy of errors around this update, sorry. |
kate-goldenring
approved these changes
Oct 6, 2026
Contributor
|
@itowlson thanks! I see how this change makes it a single bump per trigger instead of in two places where it can get lost |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we don't need to keep updating the versions.
(The repo has a slightly funky layout but I think this will still work with the way it does the pluginifying. If not, well, back to the old way.)