Skip to content

fix(ziro): restore pointer input and timestamp layout - #21

Merged
afonsojramos merged 1 commit into
mainfrom
fix/ziro-playback-hit-testing
Sep 17, 2026
Merged

afonsojramos merged 1 commit into
mainfrom
fix/ziro-playback-hit-testing

Conversation

@afonsojramos

@afonsojramos afonsojramos commented Sep 17, 2026

Copy link
Copy Markdown
Member

Ziro no longer makes Spotify appear frozen when activated: its playback timestamps stay inside the playbar instead of covering the window and intercepting clicks. Preserving Spotify's native timestamp widths also keeps the elapsed label clear of the seek bar. This ships as Ziro 0.1.4.

Verified on macOS with Spotify 1.3.0.277 using a local build: reproduced a trusted Store-button click hitting the full-window time span, then confirmed normal pointer navigation, Store disable/re-enable, and opening and closing the theme details modal after the fix. Both time spans now measure about 50 × 16 pixels. The published Store update remains to be verified after release.

Validation: 842 tests passed, 34 skipped; TypeScript and per-module strict checks, dependency checks, and formatting passed. Lint has existing warnings and no errors.

Fixes #20

Summary by CodeRabbit

  • Bug Fixes

    • Adjusted Ziro theme playback timestamps for improved positioning while preserving Spotify’s default width behavior.
  • Chores

    • Updated the Ziro theme version to 0.1.4.
    • Updated automated checks to reflect the revised timestamp styling.

Keep the timestamp parents positioned and preserve Spotify's native width
so absolute child spans neither cover the viewport nor collapse onto the
seek bar. Update the regression assertion and bump Ziro to 0.1.4.

Fixes #20
@pullfrog

pullfrog Bot commented Sep 17, 2026

Copy link
Copy Markdown

your Pullfrog Router balance is empty, and this repo has no provider key to fall back on, so the agent never ran.

To fix, any one of: add a payment method or top up your Router balance · add a provider API key (GitHub Actions secret or Pullfrog secret) · switch this repo to a free model.

Top up Router → · Model settings → · Setup docs → · Ask in Discord →

Pullfrog  | Rerun failed job ➔View workflow run | via Pullfrog𝕏

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ecdd0bfb-c1d8-445d-b2ef-c645b0804b61

📥 Commits

Reviewing files that changed from the base of the PR and between 8100acc and c07a92b.

📒 Files selected for processing (3)
  • scripts/ziro-theme.test.mts
  • themes/ziro/index.css
  • themes/ziro/metadata.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The Ziro theme changes playback-time containers from static to relative, removes their explicit width, updates the corresponding test, and bumps the theme version from 0.1.3 to 0.1.4.

Changes

Ziro playback labels

Layer / File(s) Summary
Playback label positioning
themes/ziro/index.css, scripts/ziro-theme.test.mts
Playback-time containers now use position: relative and margin: 0 without a width declaration. The test validates this shared rule.
Release version update
themes/ziro/metadata.json, scripts/ziro-theme.test.mts
The theme metadata and patch-release assertion now use version 0.1.4.

Priority: ⬆️ High

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: High

Merge Risk: ⚪ Minimal · up to c07a9

The focused CSS correction, test updates, and patch-version bump present no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Ziro fix and accurately summarizes the restored pointer input and timestamp layout changes.
Linked Issues check ✅ Passed The change satisfies issue #20. themes/ziro/index.css changes both playback-time containers to position: relative, so the absolute child spans use the containers instead of the viewport. It remove…
Out of Scope Changes check ✅ Passed The changes stay within issue #20. They modify only the affected Ziro CSS, its regression test, and the Ziro patch version required for the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ziro-playback-hit-testing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit found two labels wide,
And set their bounds to stay inside.
Relative steps replaced static flight,
Width left open, margins right.
Version four now marks the ride.

Comment @coderabbitai help to get the list of available commands.

@afonsojramos
afonsojramos merged commit 7d99365 into main Sep 17, 2026
6 of 7 checks passed
@afonsojramos
afonsojramos deleted the fix/ziro-playback-hit-testing branch September 17, 2026 09:09
@pullfrog

pullfrog Bot commented Sep 18, 2026

Copy link
Copy Markdown

Warning

Your Pullfrog Router balance is empty, and this repo has no provider key to fall back on, so every run stops before the agent starts.

The first Pullfrog run on spicetify failed, and nothing has run successfully since, so this review did not happen.

The run logged "your Pullfrog Router balance is empty" and there is no provider key stored anywhere the run can reach — no Pullfrog secrets, no GitHub Actions secrets, and no subscription auth. The account is in Router mode, so the empty wallet blocks all runs.

To fix it:

  1. Top up your Router balance on your Billing card — you can add a card and turn on auto‑reload, or fund it once.
  2. If you prefer to use your own provider key instead, add one on the BYOK tab of Billing or switch this repo to a free model — the options cover all four ways to pay for model usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ziro] Playback time labels expand to the viewport and block all pointer input

1 participant