Repository navigation
fix(portable): make the Windows x64 portable bundle start on Windows - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 7 issues discovered during Windows x64 portable bundle field testing:
portable_postgres.py):pg_ctl startwas executed withcapture_output=True, which on Windows caused the inheritedpostgreschild process pipe to blocksubprocess.run()indefinitely. Output is now redirected todata/pg_ctl.outwithstdin=subprocess.DEVNULLand a 120s timeout.scripts/portable/):start-contextcortex.batinvokes Windows PowerShell 5.1, which failed on the PowerShell 7??null-coalescing operator. Extracted the launcher and.env.exampleintoscripts/portable/with PS 5.1 compatibility and CRLF line endings via.gitattributes.start-contextcortex.ps1): Preserves_internal/certifi/cacert.pempublic root CAs when appending corporate.crt/.pemcertificates from.\certs\.main.py): SetsDATA_DIR,VAULT_PATH,CACHE_DB_PATH,VECTOR_STORE_STORAGE_PATH, andTMP_REPOS_DIRnext tocontextcortex.exebeforeapp.*imports when running frozen.main.py,.env.example): DefaultsEMBEDDING_PROVIDER=apiandEMBEDDING_MODEL=text-embedding-3-smallin frozen mode so the first startup does not create a 384-dim local FastEmbed table.litellm_service.py): Increased/v1/modelsdiscovery timeout from6.0sto15.0s.build-portable-windows.yml): Startscontextcortex.exein CI, bootstraps portable PostgreSQL +pgvector, and verifies/readyreportsstatus == 'ready'anddatabase.type == 'postgresql'before packaging the zip.