Repository navigation
fix(sync-scaffold): copy packaged docs into specfuse/loop/data/docs/ (closes #3585) - #3588
Merged
Merged
Conversation
Closes #3585. tests/test_scaffold_data_in_sync.py byte-checks the docs/ files shipped under specfuse/loop/data/docs/ and tells the reader to run scripts/sync-scaffold.sh to fix drift, but the script never copied docs/: every edit to a tracked doc failed the drift test until the file was copied by hand. All three monitoring PRs of the 0.33.0 cycle hit it. The script gains a docs stage that copies each file listed in the new scripts/sync-scaffold-docs.txt into specfuse/loop/data/docs/. The drift test reads the same list instead of its own hard-coded set, so the two cannot disagree. A listed doc missing from docs/ fails the sync; a tree with no docs/ (the bats fixtures) skips the stage. Tests: - tests/sync_scaffold.bats — listed docs are copied, a stale copy is updated, a missing listed doc fails, a tree without docs/ skips. Verification: - scripts/smoke-test.sh green: 5072 tests OK, bats suites pass, all declared gates pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
clabonte
force-pushed
the
fix/issue-3585-sync-scaffold-docs
branch
from
November 15, 2026 10:46
ebe945b to
051cca3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
test_scaffold_data_in_syncbyte-checks the docs shipped underspecfuse/loop/data/docs/and says "Run: scripts/sync-scaffold.sh" on drift, but the script never copieddocs/. Every doc edit needed a hand copy; #3581, #3582 and #3583 all hit it.Fix
scripts/sync-scaffold-docs.txt: the one list of packaged docs.sync-scaffold.shcopies each listed doc intospecfuse/loop/data/docs/. A listed doc missing fromdocs/fails the sync; a tree withoutdocs/(test fixtures) skips the stage.Tests
tests/sync_scaffold.bats: 4 new cases (copy, stale update, missing doc fails, nodocs/skips). The first three were red before the change.Verification
scripts/smoke-test.sh: 5072 tests OK, bats suites green, all gates pass.Closes #3585
🤖 Generated with Claude Code