Protect against {boolean}.to_i raising on invalid stale-while-revalidate cache control directives - #144
Merged
georgeguimaraes merged 1 commit intoSep 15, 2026
Conversation
Member
|
tks!! <3 |
georgeguimaraes
added a commit
that referenced
this pull request
Sep 15, 2026
A bare max-age or s-maxage parses as true and calling to_i on it raised NoMethodError, the same crash #144 fixed for stale-while-revalidate. Read all three integer directives through one helper that treats a valueless directive as absent, including in normalize_max_ages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid cache control directives for
stale-while-revalidateare raising here when we attempt to parse the integer value.Eg. an invalid cache-control directive such as this
The gem converts directives without values to
truehere.This PR will allow the gem to ignore these invalid values (see spec), and prevent this error from raising;
Added tests to verify behaviour.