Repository navigation
Conversation
TheRedDaemon
self-requested a review
October 15, 2026 20:27
TheRedDaemon
requested changes
Oct 15, 2026
| { | ||
| int* piVar2; | ||
| int iVar1 = 1; | ||
| piVar2 = &this->climbData[1].type; |
Contributor
There was a problem hiding this comment.
Can you try to clean the loop and type access here?
Comment on lines
+21
to
+28
| MACRO_CALL_MEMBER(OpenSHC::IO::LowLevelMemory_Func::fillMemory_ByteValue, DAT_LowLevelMemory::ptr)( | ||
| 0x27420, '\0', (void*)((int)(DAT_TileMapState::instance.PathConnectionLayer))); | ||
| MACRO_CALL_MEMBER(OpenSHC::IO::LowLevelMemory_Func::fillMemory_ByteValue, DAT_LowLevelMemory::ptr)( | ||
| 0x13a10, '\0', (void*)((int)(DAT_TileMapState::instance.PathLinkageLayer))); | ||
| MACRO_CALL_MEMBER(OpenSHC::IO::LowLevelMemory_Func::fillMemory_ByteValue, DAT_LowLevelMemory::ptr)( | ||
| 0x27420, '\0', (void*)((int)(DAT_TileMapState::instance.CertainPathLayer))); | ||
| MACRO_CALL_MEMBER(OpenSHC::IO::LowLevelMemory_Func::fillMemory_ByteValue, DAT_LowLevelMemory::ptr)( | ||
| 0x27420, '\0', (void*)((int)(DAT_TileMapState::instance.WalkLayer))); |
Contributor
There was a problem hiding this comment.
Do these numbers have a meaning? Magic numbers?
If these are just the sizes of the objects, you can try sizeof, that also creates a relationship.
| this->calculations = this->calculations + 1; | ||
| int _index = 0; | ||
| this->searchQueue.readIndex = 0; | ||
| if (this->searchQueue.writeIndex != 0) { |
Contributor
There was a problem hiding this comment.
Same thing: Can you try to clean the loop?
| handwritten assembly the frame pointer says nothing about the optimisation level: reimplement the handwritten part as | ||
| inline asm and leave the rest at `/O2`. Checking the prologue settles it - values kept in registers across the entry | ||
| tests mean `/O2`. Taking the `/Od` reading instead took `findLinkageBasedPathOrWalkRadius` from 5.1% to 2.8%, where | ||
| the same body without the pragma reaches 49.2%. When it really is `/Od`, add `#pragma optimize(, off)` |
Contributor
There was a problem hiding this comment.
Did you had a case that needed \Od?
TheRedDaemon
requested changes
Oct 15, 2026
| return; | ||
| } | ||
| this->searchQueue.readIndex = this->searchQueue.readIndex + 1; | ||
| if (0x13a10 <= (int)this->searchQueue.readIndex) { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.