Repository navigation
Conversation
Sourcegraph 8.0 moved the ping and update check routine from sourcegraph-frontend to the worker's update-check job (sourcegraph/sourcegraph#15169), so TELEMETRY_HTTP_PROXY only takes effect on worker. Update the proxy section and the frontend-specific troubleshooting steps. Amp-Thread-ID: https://ampcode.com/threads/T-01a145ed-36a6-773b-8610-aae1481725d1 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Direct preview links to pages changed in this PR: |
This comment has been minimized.
This comment has been minimized.
Amp-Thread-ID: https://ampcode.com/threads/T-01a145ed-36a6-773b-8610-aae1481725d1 Co-authored-by: Amp <amp@ampcode.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pings docs say to set
TELEMETRY_HTTP_PROXYonsourcegraph-frontend. Since 8.0.0, pings come from theworkerservice, so setting the variable on the frontend has no effect.sourcegraph/sourcegraph#15169 (
a9ca36a) moved the ping and update check routine to a newupdate-checkworker job. The only tags that contain it arev8.0.0andv8.1.0. Onmainandv8.0.0:Changes
worker, with a valid YAML example.update-checkworker job (it runs every 30 to 40 minutes, on one replica at a time). The 2022docker exec sourcegraph-frontend-0 … grep updatecheckgoroutine check is replaced by a check that the worker job allow and block lists (theWORKER_JOB_*variables) includeupdate-check. The goroutine is now ininternal/pings, and its stack doesn't showupdatecheckbetween runs. The log step now points to theworkerlogs (updatecheck failed), and the search link to the deletedcmd/frontend/internal/app/updatecheck/client.gois gone.Backport to the 8.0 docs: sourcegraph/docs-legacy-versions#213.
Test plan
--check-anchors --check-self-links --check-external): no new dead links.npx cspell@10 docs/admin/pings.mdx: 0 issues.Amp thread: https://ampcode.com/threads/T-01a145ed-36a6-773b-8610-aae1481725d1