Skip to content

ux: focus input-less popups #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corebonts wants to merge 1 commit into
base: develop
Choose a base branch
from
+19 −1
Open

ux: focus input-less popups #2679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/Views/PopupDataTemplates.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using Avalonia.Controls;
using System.Linq;

using Avalonia.Controls;
using Avalonia.Controls.Templates;
using Avalonia.Input;
using Avalonia.VisualTree;
Expand Down Expand Up @@ -35,6 +37,22 @@ public Control Build(object param)
return;
}
}

var host = ctl.GetVisualAncestors().OfType<Control>().FirstOrDefault(c => c.Name == "PopupPanel");
if (host == null)
return;

foreach (var input in host.GetVisualDescendants())
{
if (input is SelectableTextBlock)
continue;

if (input is Control { Focusable: true, IsVisible: true, IsEffectivelyVisible: true, IsEffectivelyEnabled: true } focusable)
{
focusable.Focus(NavigationMethod.Directional);
return;
}
}
};

return control;
Expand Down