Skip to content

fix: hide console window when launching external tools - #2731

Merged
love-linger merged 1 commit into
sourcegit-org:developfrom
weiningwei:fix/external-tool-console-flash
Sep 21, 2026
Merged

love-linger merged 1 commit into
sourcegit-org:developfrom
weiningwei:fix/external-tool-console-flash

Conversation

@weiningwei

Copy link
Copy Markdown
Contributor

Windows version of zed.exe is compiled as a console-subsystem executable (it doubles as the CLI). Since SourceGit is a GUI app without a console, starting a console-subsystem child via Process.Start with UseShellExecute = false causes Windows to allocate a new console window, which briefly flashes and then disappears after the CLI hands off to the editor.

Set CreateNoWindow = true in ExternalTool.Launch() to suppress the console allocation. It has no effect on GUI-subsystem executables such as Code.exe.

@love-linger love-linger self-assigned this Sep 21, 2026
@love-linger love-linger added enhancement New feature or request os-windows This issue only exists on Windows labels Sep 21, 2026
@love-linger
love-linger merged commit aafc545 into sourcegit-org:develop Sep 21, 2026
14 checks passed
@weiningwei
weiningwei deleted the fix/external-tool-console-flash branch September 21, 2026 13:56
ftovagliari pushed a commit to ftovagliari/sourcegit that referenced this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request os-windows This issue only exists on Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants