Skip to content

current diff view sometimes broken (in DEV) #2001

Closed

Description

@mithom

i was running a dev build because i was testing the new changes i requested when i encountered the following issue:
Image

this does not happen in the current master build.
a very quick glance at the recent commits makes me think commit b84b793 might have broken this view. I haven't had time to go into detail. i probably was way to quick and that commit might totally not be the cause
Reporting this issue so this can be fixed before a new release happens, if this is considered not an issue as it is only in dev, feel free to close it immediately.

Activity

  1. self-assigned this
    on Dec 23, 2025
  2. love-linger commented on Dec 23, 2025

    @love-linger
    Collaborator

    Can you find a way to stably reproduce it?

  3. mithom commented on Dec 23, 2025

    @mithom
    ContributorAuthor

    I will try to, at first glance i did not see a pattern as it was only in about half of the files. I'll use the dev build again today and see if i can get something consistent.

  4. added a commit that references this issue on Dec 29, 2025
    50d0865
  5. sina-hide commented on Dec 29, 2025

    @sina-hide
    Contributor

    Hi @mithom, your first idea was right: My commit b84b79 (#1996) introduced the regression bug you've seen. I've fixed it in #2015. You may have seen this bug only sometimes, since it is only triggered for files with CR/LF as newlines (I suspect you're using Windows). With LF as newline this bug is not triggered (even on Windows).

  6. added a commit that references this issue on Dec 29, 2025
    df3acff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

need-more-infoExtra information or replay is needed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions