Repository navigation
fix: keep the Vitest test config when solid-js is already external - #455
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: d0e47f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In test mode the plugin only returns its
testconfig when it also setstest.server. When the user config already listssolid-jsintest.server.deps.external, the plugin skipstest.serverand drops the wholetestblock with it, so Vitest gets neither thejsdomenvironment nor the@testing-library/jest-domsetup file. Component tests that rely on the DOM or on jest-dom matchers then fail.This started with #183, which moved the config into a fresh
testobject but kepttest.serveras the condition for returning it.Changes
testwhenever it has any key, the same check thenextbranch uses.test:unitscript, a rootvitest.config.tsandsrc/test-config.test.ts, and run the unit tests in the Vitest workflow.Testing
pnpm run test:unit: 2 passed. With thesrc/index.tschange reverted, the new externalsolid-jscase fails (expected undefined to be 'jsdom').pnpm run buildand Prettier pass.Fixes #454