Repository navigation
Conversation
- Add a root vitest config and a test:unit script, matching the next branch. - Run the unit tests in the vitest workflow. - Exclude test files from the declaration build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Without `ssr: true`, modules loaded on the server were compiled to DOM output and threw "Client-only API called on the server side". - Server transforms now use `generate: 'ssr'` with `hydratable: false`, so a client-rendered app can prerender pages with `ssrLoadModule`. - Client transforms and Vitest keep DOM output. Fixes #64 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: cd79ed9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64 on
main(1.x). The fix fornextis in a separate PR.Without
ssr: true, modules loaded on the server are now compiled to SSR output. A client-rendered app can now prerender pages withssrLoadModule. Before, those modules were compiled to DOM output and threwClient-only API called on the server side.Changes
ssris off, server transforms usegenerate: 'ssr'withhydratable: false.ssr: truethe behavior is unchanged.solid.generatealso applies to the client, and ababelfunction cannot replace the preset.ssroption's JSDoc and README entry describe the new behavior.main, Vitest adds thebrowsercondition, sosolid-js/webresolves to the browser build, wheressr()is an empty stub. Keeping DOM output avoids breaking DOM tests that run inenvironment: 'node'.Note on the first commit
The first commit adds the Vitest unit-test setup. It is the same commit as in the other
mainfix PRs from this batch, so they do not conflict on it.Behavior change
Anyone who loads modules on the server without
ssr: truenow gets SSR output instead of DOM output. DOM output could not run on the server, so this should only affect setups that loaded those modules without rendering them.Testing
src/ssr-codegen.test.ts. It fails without the fix: the server transform still containstemplate.pnpm test:unitandtsc --noEmitpass. The Cypress suite for the vite-3 to vite-8 examples passes.🤖 Generated with Claude Code