Repository navigation
Conversation
- Add a root vitest config and a test:unit script, matching the next branch. - Run the unit tests in the vitest workflow. - Exclude test files from the declaration build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Vitest before 1.0 resolves setupFiles with require.resolve (local-pkg 0.4), which picks jest-dom's CommonJS vitest entry. That file reads require('vitest').expect, which is undefined, and throws "Cannot read properties of undefined (reading 'extend')".
- When the project's vitest is older than 1.0, inject the absolute path of jest-dom's ESM vitest entry instead of the bare specifier.
- Vitest 1.0+ keeps the bare specifier.
- Add tests for both vitest ranges.
Fixes #141
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: a7ec25f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141 on
main(1.x).nextrequires Vite 8, which Vitest before 1.0 cannot run, so it is not affected.With Vitest before 1.0, the jest-dom setup file the plugin injects now loads. Before, tests failed with
Cannot read properties of undefined (reading 'extend').Cause
setupFileswithrequire.resolve. That picks jest-dom's CommonJSdist/vitest.js, whererequire('vitest').expectis undefined.@testing-library/jest-dom/vitestautomatically.Changes
Testing
vitest runandtsc --noEmitpass.Note on the first commit
mainhad no unit tests. The first commit adds the same Vitest setup thatnextuses: a rootvitest.config.ts, atest:unitscript, and a step in the Vitest workflow. The othermainfix PRs from this batch (#112, #153, #206, #130, #141) share this exact commit, so they do not conflict on it.🤖 Generated with Claude Code