fix(2.0): niche cases for DCE

[lxsmnsyc]

Fixes #2160
Fixes #2168

[changeset-bot]

🦋 Changeset detected

Latest commit: 4625a17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@solidjs/start	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for solid-start-landing-page ready!

Name	Link
🔨 Latest commit	4625a17
🔍 Latest deploy log	https://app.netlify.com/projects/solid-start-landing-page/deploys/6a54ce4afa05f9000868d04b
😎 Deploy Preview	https://deploy-preview-2161--solid-start-landing-page.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2161

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2161

commit: 4625a17

[katywings]

Lovely fixes <3. Thank you @lxsmnsyc. I am adding a couple tests in a few moments.

[lxsmnsyc]

Added a change.

Moved the directives compiler step before Solid's so that the compiler's aggressive DCE can run first.

[katywings]

@lxsmnsyc Great addition 👍. I gonna add a test for that case as well tomorrow or on wednesday :).

[katywings]

@lxsmnsyc All looking good to me 🎉. I also quickly ran a Nitropage build with this branch and it ran just fine!