Skip to content

[Android] Allow GestureStateManager.activate from the first onTouchesDown #4534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 3 commits into from
Sep 28, 2026
Merged

[Android] Allow GestureStateManager.activate from the first onTouchesDown #4534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52a01c4
Android manualActivation
m-bert Sep 22, 2026
dfda93b
Don't check pointers on begin
m-bert Sep 22, 2026
380166c
Remove recordHandlerIfNotPresent
m-bert Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,9 @@ open class GestureHandler {
return localPointerId
}

val hasTrackedPointers: Boolean
get() = trackedPointersIDsCount > 0

fun startTrackingPointer(pointerId: Int) {
if (isTrackingPointer(pointerId)) {
return
Expand Down Expand Up @@ -801,10 +804,6 @@ open class GestureHandler {
protected open fun onCancel() {}
protected open fun onFail() {}

fun recordHandlerIfNotPresent() {
hostDetectorView?.recordHandlerIfNotPresent(this)
}

private fun isButtonInConfig(clickedButton: Int): Boolean {
if (mouseButton == 0) {
return clickedButton == MotionEvent.BUTTON_PRIMARY
Expand Down
8 changes: 6 additions & 2 deletions ...andler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,15 @@ class RNGestureHandlerModule(reactContext: ReactApplicationContext?) :

registry.getHandler(handlerTag)?.let { handler ->
if (newState == GestureHandler.STATE_ACTIVE) {
// The first touch event reaches JS before the handler begins, so a handler
// that already tracks a pointer may still be UNDETERMINED here.
if (handler.hasTrackedPointers && handler.state == GestureHandler.STATE_UNDETERMINED) {
handler.begin()
}

if (handler.state != GestureHandler.STATE_BEGAN) {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
// We don't allow activation of gestures which haven't received any touches
return
}
handler.recordHandlerIfNotPresent()
}

when (newState) {
Expand Down
Loading