Skip to content

Document Intel vs Apple Silicon Homebrew paths in OSX-NOTES.md#893

Merged
jschlyter merged 2 commits into
softhsm:mainfrom
zkharit:docs/osx-notes-apple-silicon
Jul 18, 2026
Merged

Document Intel vs Apple Silicon Homebrew paths in OSX-NOTES.md#893
jschlyter merged 2 commits into
softhsm:mainfrom
zkharit:docs/osx-notes-apple-silicon

Conversation

@zkharit

@zkharit zkharit commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Homebrew installs to /usr/local on Intel Macs but /opt/homebrew on Apple Silicon, and OpenSSL is now a versioned keg (openssl@3). The configure example only showed the Intel paths, causing "Can't find OpenSSL headers" on Apple Silicon machines. Show both variants plus a portable brew --prefix form.

Summary by CodeRabbit

  • Documentation
    • Updated macOS build instructions to support both Intel and Apple Silicon Macs.
    • Added architecture-appropriate Homebrew paths and a portable brew --prefix configuration option.
    • Clarified versioned OpenSSL and SQLite configuration requirements.
    • Improved troubleshooting guidance for missing OpenSSL headers.

Homebrew installs to /usr/local on Intel Macs but /opt/homebrew on
Apple Silicon, and OpenSSL is now a versioned keg (openssl@3). The
configure example only showed the Intel paths, causing "Can't find
OpenSSL headers" on Apple Silicon machines. Show both variants plus
a portable brew --prefix form.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@zkharit
zkharit requested a review from a team as a code owner July 17, 2026 20:21
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 693dbe4e-b122-4e5e-91d3-5469bae814f4

📥 Commits

Reviewing files that changed from the base of the PR and between 10736ee and f0e331f.

📒 Files selected for processing (1)
  • OSX-NOTES.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • OSX-NOTES.md

📝 Walkthrough

Walkthrough

The macOS build notes update Homebrew path guidance for Intel and Apple Silicon Macs, add versioned OpenSSL instructions, provide portable brew --prefix configuration examples, and revise OpenSSL header troubleshooting.

Changes

macOS build documentation

Layer / File(s) Summary
Homebrew paths and configure guidance
OSX-NOTES.md
Homebrew prefixes, versioned openssl@3 paths, architecture-specific configure commands, portable prefix commands, and OpenSSL header troubleshooting are updated.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main documentation update for Intel and Apple Silicon Homebrew paths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@OSX-NOTES.md`:
- Around line 62-63: Update the command examples in OSX-NOTES.md by removing the
leading “$” prompts from the brew commands, since no command output is shown.
Keep the commands themselves unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fdb7c184-1b8f-45bc-8797-0f3e9fc67b07

📥 Commits

Reviewing files that changed from the base of the PR and between f59e8f4 and 10736ee.

📒 Files selected for processing (1)
  • OSX-NOTES.md

Comment thread OSX-NOTES.md Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@jschlyter
jschlyter merged commit f12916e into softhsm:main Jul 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants