Skip to content

[LinearSystem] MatrixProjectionMethod : add checks while adding to GlobalMatrix (in debug) - #6257

Open
fredroy wants to merge 1 commit into
sofa-framework:masterfrom
fredroy:add_checks_matrixprojectionmethod
Open

[LinearSystem] MatrixProjectionMethod : add checks while adding to GlobalMatrix (in debug)#6257
fredroy wants to merge 1 commit into
sofa-framework:masterfrom
fredroy:add_checks_matrixprojectionmethod

Conversation

@fredroy

@fredroy fredroy commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

advised by Claude while trying to fix

I set only the checks only in debug to avoid loss of perf but maybe it could enabled in any case 🤔

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI labels Aug 25, 2026
@fredroy
fredroy requested a review from alxbilger August 25, 2026 00:14

@alxbilger alxbilger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a problematic scene. I got the following error:

[ERROR]   [MatrixProjectionMethod] A projected matrix block of size 120x960 placed at (0, 1080) does not fit into the global matrix of size 1200x1200. The block is ignored.

@alxbilger alxbilger added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants