Repository navigation
Conversation
…ding The discovered-datasets list can trail the discovery that fills it, and its onboarded flag can trail an onboarding. datasource onboard now waits until the count is the same on two polls in a row, and dataset list no longer shows a just-onboarded dataset a second time as not onboarded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Soda Cloud is moving the discovered-datasets list to a read replica, so the list can trail the database by a few seconds. Two commands assume it is always current.
sodacli datasource onboardstops waiting at the first non-empty list. If the replica has copied only part of a discovery, the user is offered only some of the tables to onboard.sodacli dataset listhides discovered datasets that are marked onboarded. Right after an onboarding, the replica still marks them as not onboarded, so for a few seconds they show up twice: once as onboarded and once as not onboarded.Change
datasource onboardwaits until the discovered count is the same on two polls in a row, which costs one extra poll of 5 seconds. The 5-minute timeout stays.dataset listalso hides a discovered dataset when its qualified name matches an onboarded dataset in the same output.Testing
go build,go vetand the offline CLI tests pass. There are no unit tests for these commands, and I have not run them against a live org.🤖 Generated with Claude Code