so3: state the architecture in the boot banner - #306
Merged
Conversation
Version 6.2.3 becomes Version 6.2.3 (arm64) The same platform can be built either way, and on a Raspberry Pi 4 the 32- and the 64-bit chains differ only by which kernel*.img the firmware picks up — so nothing on the console told you which one had actually booted. Print CONFIG_ARCH, the string Kconfig already defines, so this needs no maintenance when an architecture is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The same platform can be built either way, and on a Raspberry Pi 4 the 32- and the 64-bit chains differ only by which
kernel*.imgthe firmware picks up. Nothing on the console told you which one had actually booted — which is exactly the kind of thing you want to read off the log rather than infer.What
Uses
CONFIG_ARCH— the string Kconfig already defines (#define CONFIG_ARCH "arm64") — so it needs no maintenance when an architecture is added, and it is a compile-time constant, so the banner stays a plain macro.Test
Booted on real hardware (RPi 4 Model B), both chains:
Version 6.2.3 (arm32)Version 6.2.3 (arm64)