Skip to content

cre-6391: refactor of ShardID into DonID as being the same - #23658

Open
mchain0 wants to merge 4 commits into
cre-4799from
cre-6391
Open

cre-6391: refactor of ShardID into DonID as being the same#23658
mchain0 wants to merge 4 commits into
cre-4799from
cre-6391

Conversation

@mchain0

@mchain0 mchain0 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

refactor of ShardID into DonID as being the same

CRE-6391

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting cre-4799

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Sep 4, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
FuzzParse A goroutine attempted to log after the test had already completed, causing a panic due to a failed connection dial in the pipeline bridge component. Logs ↗︎
FuzzParse/seed#0 A goroutine attempted to log after the test had already completed, causing a panic due to improper logging after test termination. Logs ↗︎

View Full Report ↗︎Docs

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@mchain0
mchain0 marked this pull request as ready for review September 4, 2026 12:28
@mchain0
mchain0 requested review from a team as code owners September 4, 2026 12:28
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants