fix(workflows/v2): log err on decryption share failures and fix share count - #23653
Open
prashantkumar1982 wants to merge 2 commits into
Open
fix(workflows/v2): log err on decryption share failures and fix share count#23653prashantkumar1982 wants to merge 2 commits into
prashantkumar1982 wants to merge 2 commits into
Conversation
… count The decryption share loop was discarding the underlying error when decrypt/unmarshal/verify failed, making debugging difficult. Add the error to each debug log. Also fix the 'not enough decryption shares' error to report the count of successfully collected shares instead of the total encrypted shares. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
👋 prashantkumar1982, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
… into fix/vault-decryption-share-err-logging
Contributor
|
I see you updated files related to
|
|
russell-stern
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In
decryptSecret(core/services/workflows/v2/secrets.go), the loop that collects decryption shares was swallowing the underlying error whenever decrypt, unmarshal, or verify failed. This made it hard to debug why shares were being dropped.Additionally, the "not enough decryption shares" error reported
len(encryptedDecryptionShares)(the total input) rather thanlen(decryptionShares)(the number successfully collected), giving a misleading "have N" count.