Skip to content

Vault atomic settings - #23650

Draft
russell-stern wants to merge 8 commits into
developfrom
vault_atomic_flags_new
Draft

Vault atomic settings#23650
russell-stern wants to merge 8 commits into
developfrom
vault_atomic_flags_new

Conversation

@russell-stern

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 5 @smartcontractkit/foundations, @smartcontractkit/core
/core/capabilities/ 2 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
/core/services/ocr*/ 8 @smartcontractkit/foundations, @smartcontractkit/core
/.github/** 1 @smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core
go.mod 7 @smartcontractkit/core, @smartcontractkit/foundations
go.sum 7 @smartcontractkit/core, @smartcontractkit/foundations
integration-tests/go.mod 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations
integration-tests/go.sum 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Sep 3, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@russell-stern

Copy link
Copy Markdown
Contributor Author

/vault-audit model=opus

@app-token-issuer-foundations

app-token-issuer-foundations Bot commented Sep 3, 2026

Copy link
Copy Markdown

⚠️ Vault audit complete for 4dd177396 blocking finding(s) (CRITICAL/MUST FIX) must be addressed before merge.

📋 View the full report and findings — private tracking issue, visible to chainlink team members only. Resolve blocking findings there with /resolved <FINDING-ID> <reason>.

@app-token-issuer-foundations

Copy link
Copy Markdown

✅ All vault-audit blocking findings on this PR have been resolved by reviewers. The vault-audit status check is now green.

📋 Tracking issue

@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant